yii: PHP 7.2: count(): Parameter must be an array or an object that implements Countable

What steps will reproduce the problem?

A lot of tests on PHP 7.2 are failing with

count(): Parameter must be an array or an object that implements Countable

count() throws a warning since PHP 7.2 in case a scalar or non-countable object is passed. We rely on this behavior in many places so code needs to be adjusted.

Need to check how many places are affected and whether its easy to fix. If its hard to fix in a BC way, PHP 7.1 may be the last version that Yii 1.1 runs on.

More info

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 26 (15 by maintainers)

Commits related to this issue

Additional fix for #4167 — committed to yiisoft/yii by samdark 6 years ago
Fixes #4167: Fixed PHP 7.2 incompatibility of "count()" in `CActiveFinder` and CController::renderDynamic() — committed to yiisoft/yii by ThePepster 6 years ago

Most upvoted comments

Partly fixed.

samdark on Jan 25, 2018

Not a good idea for now.

samdark on Dec 5, 2017

Hope having it soon. We have 7.2 tests now and these are passing.

samdark on Jan 30, 2018

There is another issue in CActiveFinder in queryOneMany in line if(count($fks)!==count($pkTable->primaryKey)) If primaryKey is string the count() doesn’t work. It can be easy fixed with: if(count($fks)!==count(array($pkTable->primaryKey)))

aztechowski on May 11, 2018

There is another one on framework/gii/generators/model/ModelCode.php:371 Fixed it with

...
$pk=$table->primaryKey;
$count=is_array($pk) ? count($pk) : 1;
return ($count === 2 // we want 2 columns
...

AbuMuhammad on Feb 3, 2018

I’ve checked trunk version and it looks it is already fixed with https://github.com/yiisoft/yii/commit/05d2c67555e8b67ef54906148775997acf018840. The latest version 1.1.19 is not. What are plans regarding 7.2 compatibility? When the next release that is 7.2 compatible will be released?

aztechowski on May 14, 2018

Here are 7.2 compatibility fixes: https://github.com/b1rdex/yii/commit/713a80e32654e720fbd22b77594c3328a8994dd9 https://github.com/b1rdex/yii/commit/8a8ac14ab925df683ecd481c986662acf885c96c https://github.com/b1rdex/yii/commit/972c3b62d17f7ba1a122c05a867aa0f73d1f89ca

b1rdex on Dec 26, 2017

If you pass a scalar value as $values the count() will return 1, which gets you into the elseif($n===1) branch. There you have $value = reset($values), which would fail because reset() expects an array.

So I do not see how your code runs fine in other PHP versions < 7.2: https://3v4l.org/nHrpA

Thank you @cebe and @rob006 for this feedback.

I have taken this opportunity to audit all our application code that uses CDbCriteria::addInCondition() and ::addNotInCondition(). All instances except one pass an array as the $value parameter. The one case where a non-array is (sometimes) passed, it’s always empty. I will fix the application code in this one case.

jjdunn on Oct 26, 2018