berry: [Bug?]: supported architectures behaviour doesn't support zero installs

Self-service

I’d be willing to implement a fix

Describe the bug

I have a repo using zero installs approach that requires one unplugged package (@swc-core)

its unplugged as it appears to require platform specific binaries. My CI environment is a linux env, whereas local is mac

I added the specific platforms to the supportedArchitectures field in my .yarnrc.yml

I had hoped/expected that with zero-installs the platform specific binaries would have been installed/added to the repo on local install so that when i run my ci i do not need to do a yarn install step (in keeping with the zero installs approach)

This may be the intended behaviour, but then how do I maintain zero installs in this case?

To reproduce

I don’t believe this can be reproduced in sherlock due to the cross platform nature of the issue

Environment

System:
    OS: macOS 11.6.5
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Binaries:
    Node: 16.15.1 - /private/var/folders/bl/q3538n111qsck6ll41877f440000gp/T/xfs-d4f8e23c/node
    Yarn: 3.2.1 - /private/var/folders/bl/q3538n111qsck6ll41877f440000gp/T/xfs-d4f8e23c/yarn
    npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm

Additional context

Screen Shot 2022-07-08 at 10 57 50 AM

Here’s the ci error if i do not include yarn install step

Yarnrc file

plugins:
  - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
    spec: "@yarnpkg/plugin-interactive-tools"

yarnPath: .yarn/releases/yarn-3.2.1.cjs

supportedArchitectures:
  os:
    - darwin
    - linux

About this issue

Original URL
State: closed
Created 2 years ago
Reactions: 2
Comments: 17 (1 by maintainers)

Most upvoted comments

Ok seems it does work,

But they need all supportedArchitectures critieria

needed to specify both cpu and libc sub options for @swc-core-linux-x64-gnu-npm to be installed

Even with yarn@4, This continues to be the case for supportedArchitectures to behave correctly (all 3 options need to be specified, in order to install binaries for all of them). Maybe this will save someone some time. Don’t know if bug or feature at the time of writing.

Example working config:

supportedArchitectures:
  os:
    - current
    - darwin
    - linux
  cpu:
    - current
    - x64
    - arm64
  libc:
    - current
    - glibc
    - musl

pegiadise on Oct 26, 2023

Thanks for the update.

I’ve moved away from using zero installs mostly due to issues like this, so I no longer check in my yarn cache

laytong on Dec 27, 2023

@laytong this is still broken on yarn@4 It’s still too puzzling why esbuild / swc doesn’t get resolved properly from time to time. @pegiadise yup, it still persists and it’s a bug.

Downgrading to 3.7.0 helps atm. yarn set version 3.7.0 fixes things…

yuriy-yarosh on Dec 21, 2023

Ok seems it does work,

But they need all supportedArchitectures critieria

needed to specify both cpu and libc sub options for @swc-core-linux-x64-gnu-npm to be installed

laytong on Jul 11, 2022

So when using my local (Mac) env it installs the darwin specific prebuilt binary (which is at least better than all binaries) to the unplugged folder.

Ideally when using supportedArchitectures it would grab all binaries that meet my specified platforms?

On Sat., Jul. 9, 2022, 10:24 Seivan, @.***> wrote:

Do you know if SWC supplies prebuilt binaries for each platform?

For instance, ESBuild does that, running install locally, gives me all the binaries (arm, x64, darwin, linux) etc. They are part of the repo.

Unless the package supplies prebuilt binaries or cross-build install script, there really isn’t much you can do.

— Reply to this email directly, view it on GitHub https://github.com/yarnpkg/berry/issues/4615#issuecomment-1179577433, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJVU776YC723DQSOFAH3NDVTGYTBANCNFSM53BXCICQ . You are receiving this because you authored the thread.Message ID: @.***>

laytong on Jul 9, 2022