berry: [Bug] Slower link w/ the nm linker

I’d be willing to implement a fix

Describe the bug

A simple require does not work because of hoisting.

To Reproduce

git clone git@github.com:bertho-zero/yarn-bug-repro.git
cd yarn-bug-repro/packages/package-1
yarn start

Screenshots

Environment

OS: Linux
Node version v12.16.1
Yarn version 2.0.0-rc.33

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 19 (11 by maintainers)

Most upvoted comments

Reopening to keep track of the memory issue

arcanis on May 12, 2020

@eigilsagafos @arcanis Well, I believe these issues have the same cause and I’m working to fix it. It will take some time though, because of hoisting problem complexity.

larixer on May 28, 2020

Looking good @larixer! Cached I’m now seeing 5.55 seconds vs 6.46 seconds in loose mode (edit: I’m on a new laptop so that might have resulted in overall faster linking compared to my previous results)

eigilsagafos on Jun 6, 2020