xterm.js: Browser crash related to fit addon returning geometry with "Infinity" sizes

screenshot 2018-04-25 18 34 47

Appears to be caused by edge cases around offscreen xterms coming/going onscreen. With term.renderer.dimensions.actualCellWidth as null, fit returns Infinity. If you allow xterm to try to resize itself to Infinity, it consumes all available RAM and crashes the browser.

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 1
Comments: 26 (22 by maintainers)

Commits related to this issue

Generalize verify integers check Fixes #1416 — committed to Tyriar/xterm.js by Tyriar 5 years ago

Most upvoted comments

I just noticed the requirement that xterm has that the parent be visible when open is called. We might be in the wrong, here, so I’ll try to take a second look later.

vincentwoo on May 4, 2018