github-action-wait-for-status: wait-for-status triggered on pull_request fails to detect failed jobs
[UPDATE]: Since 5786ef2, wait-for-status triggered on pull_request does not detect failed jobs. See https://github.com/WyriHaximus/github-action-wait-for-status/issues/21#issuecomment-670522475
Hi !
Since we upgraded from d2ddfe5 to v1 all our check jobs finish in success with a weird message (since other jobs are already in progress) : No statuses found, assuming success.
I would have linked one of our jobs here, but since it also happens in the CI here, juste see your CI logs 😄 : https://github.com/WyriHaximus/github-action-wait-for-status/runs/907377690?check_suite_focus=true
It seems pretty weird to me. Is it intended ?
PS: Still love your action anyway ❤️
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 19 (12 by maintainers)
@Crow-EH ok I think I’ve figured it out.
merge_commit_shaof that PR when looking at the API https://api.github.com/repos/Crow-EH/github-action-wait-for-status-issue-21/pulls/13TL;DR when detecting it’s ran on a PR, I can get the
merge_commit_shafrom the PR and check against that when it’s detected that the action is ran in a PR 🎉@Crow-EH detection seems to be working: https://github.com/WyriHaximus/github-action-wait-for-status/runs/1038925268?check_suite_focus=true#step:4:133 WIP PR at #29
Ok cool as expected! I’ll start on PR detection then. Thanks 👍
@Crow-EH OK v1.1 is out. Can you run against that for me? Interested in the output. Looking into the PR vs push difference next
@Crow-EH absolutely awesome write up, I’ll have a long look at it tomorrow 👍
Ok cool thanks, will have a look at that. Also if you have a simple reproduction project, even a commit would be enough to test against that would be amazing 👍
Look at https://github.com/ekino/docker-buildbox/pull/313 you are only using Github Actions correct? So within the Github API there are two kinds of commit “statuses” the older
statusesand the newerchecks. Generally, that message means it couldn’t find anystatusesand just assumes those are fine, but it doesn’t ignore anychecks. I’ll see how I can improve this 👍 , thank you for reporting