wro4j: Parallel pre processing is not enabled with maven plugin.

What steps will reproduce the problem?
1. Create a maven pom file with <extraConfigFile> pointing to a properties file 
which has a parallelPreprocessing option turned on
2. Use ro.isdc.wro.maven.plugin.manager.factory.ConfigurableWroManagerFactory 
as the wroManagerFactory
3. Run jshint goal.

What is the expected output? What do you see instead?
The jshint should be ran across the files, in parallel. But they are not. This 
can be quite slow if I have a project with lots of javascript files.


What version of the product are you using? On what operating system?
1.4.7, windows.


Please provide any additional information below.

I have the following maven plugin configuration:
-------------------------------
 <plugin>
                        <groupId>ro.isdc.wro4j</groupId>
                        <artifactId>wro4j-maven-plugin</artifactId>
                        <version>1.4.7</version>
                        <executions>
                            <execution>
                                <id>test-jshint</id>
                                <phase>validate</phase>
                                <goals>
                                    <goal>jshint</goal>
                                </goals>
                                <configuration>
                                    <wroFile>${basedir}/src/main/webapp/WEB-INF/wro-jshint.xml</wroFile>
                                    <options>browser,curly,forin,immed,latedef,trailing</options>
                                    <failNever>false</failNever>
                                    <targetGroups>core-javascript</targetGroups>
                                    <extraConfigFile>${basedir}/src/test/resources/wro.properties</extraConfigFile>
                                    <wroManagerFactory>ro.isdc.wro.maven.plugin.manager.factory.ConfigurableWroManagerFactory</wroManagerFactory>
                                </configuration>
                            </execution>
                        </executions>
</plugin>
-------------------------------

and the wro.properties file:
-------------------------------
parallelPreprocessing=true
-------------------------------


and my wro-jshint.xml file:
---------------------
<?xml version="1.0" encoding="UTF-8"?>
<groups xmlns="http://www.isdc.ro/wro">
    <!-- used for maven wro4j plugin to determine which js files are subject to jshint checks -->
    <group name='core-javascript'>
        <js>/blades/**.js</js>
    </group>
</groups>
-----------------------

Although I have specified the parallelPreprocessing flag, the jshint were not 
ran in parallel. I have created a patch file which I think should fix this. 
This improves my build time from 60 secs down to 19 secs.







Original issue reported on code.google.com by AlexWib...@gmail.com on 4 Sep 2013 at 12:24

Attachments:

About this issue

  • Original URL
  • State: closed
  • Created 12 years ago
  • Comments: 16

Most upvoted comments