wp-cli: Use of WP_CLI\Utils\run_mysql_command() broken on Windows 10

Looks like PHP 8+ has a Windows compat bug fix, which causes our workaround to break…

Is there any chance to get this fixed @schlessera or what is required to move this issue forward? WP CLI defines support for PHP ^8.0 but it seems not really to work - at least on Windows. 🤔

We have the same issue for other operations, e.g. remove of plugin:

C:\Users\Administrator>c:\php-8.0\php.exe -dsafe_mode=off -ddisplay_errors=on -dopen_basedir=  -d max_execution_time=60 "C:\wp-cli.phar" "--path=C:\Inetpub\vhosts\abc.tld\httpdocs" --debug  --no-color plugin uninstall akismet "--skip-plugins=akismet,hello,thanks_for_read"
...
Debug (hooks): On hook "before_run_command": WP_CLI\Bootstrap\RegisterDeferredCommands->add_deferred_commands() (9.385s)
Debug (bootstrap): Running command: plugin uninstall (9.387s)

C:\Users\Administrator>echo %errorlevel%
1

Plugin files are not removed!

Environment: Windows, PHP 8.0, for example:

C:\Users\Administrator>c:\php-8.0\php.exe -dsafe_mode=off -ddisplay_errors=on -dopen_basedir=  -d max_execution_time=60 "C:\wp-cli.phar" --info
OS:     Windows NT 10.0 build 14393 (Windows Server 2016) AMD64
Shell:  C:\Windows\system32\cmd.exe
PHP binary:     c:\php-8.0\php.exe
PHP version:    8.0.21
php.ini used:   C:\Program Files (x86)\Plesk\Additional\PleskPHP80\php.ini
MySQL binary:
MySQL version:
SQL modes:
WP-CLI root dir:        phar://wp-cli.phar/vendor/wp-cli/wp-cli
WP-CLI vendor dir:      phar://wp-cli.phar/vendor
WP_CLI phar path:       C:\Users\Administrator
WP-CLI packages dir:
WP-CLI global config:
WP-CLI project config:
WP-CLI version: 2.6.0

Once I comment out

	// Need to encompass the whole command in double quotes - PHP bug https://bugs.php.net/bug.php?id=49139
	cmd = '"' . _proc_open_compat_win_env( $cmd, $env ) . '"';

at utils.php, plugin remove works perfectly.

Also, switch to PHP 7.4 helps.

Could you please fix compatibility of WP-CLI with PHP 8.0 and later on Windows?

Any idea when this fix will be released as a stable version ?

@thiervoj We’re currently targeting the first week of March.

Everything works fine when I use the wp cli update, it seems to be ne nightly build that is not succeeding to install.

Interesting! Mind opening a new bug report for that?

You can also directly download the nightly:

curl -O https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli-nightly.phar

I’ve tested the nightly build on Windows 10 against:

1. PHP 7.4
2. PHP 8.0
3. PHP 8.1

Everything appears to be working.

I also ran the test suite as mentioned here.

Thanks for your work on those pull requests, @lipemat

I chatted with @schlessera yesterday. We’re fine to land them, let them soak in the nightly build, and see if there’s any fallout.

I also created https://github.com/wp-cli/wp-cli-tests/issues/155 so we can try to prevent this in the future. However, given we probably can’t recreate every Windows environment, we might want to create a @wp-cli/windows-users GitHub group for volunteers who might be willing to run the test suite in their local environment before each release.

I submitted pull requests to resolve this issue:

1. https://github.com/wp-cli/db-command/pull/231
2. https://github.com/wp-cli/wp-cli/pull/5689

I am having this issue as well when I run the following command, I get the following output.

$ wp config create --dbname=myTestDb --dbuser=root --dbpass=rootbeer
'"mysql --no-defaults --execute="' is not recognized as an internal or external command,
operable program or batch file.

I have verfied that mysql is in my path with the following:

$ mysql --version
C:\Program Files\MySQL\MySQL Server 8.0\bin\mysql.exe  Ver 8.0.23 for Win64 on x86_64 (MySQL Community Server - GPL)

This is the output from command wp --info

$ wp --info
OS:     Windows NT 10.0 build 19043 (Windows 10) i586
Shell:  C:\Program Files\Git\usr\bin\bash.exe
PHP binary:     C:\PHP\php.exe
PHP version:    8.0.12
php.ini used:   C:\PHP\php.ini
MySQL binary:
MySQL version:
SQL modes:
WP-CLI root dir:        phar://wp-cli.phar/vendor/wp-cli/wp-cli
WP-CLI vendor dir:      phar://wp-cli.phar/vendor
WP_CLI phar path:       C:\Sites\markdurb.in\wordpress
WP-CLI packages dir:
WP-CLI global config:
WP-CLI project config:
WP-CLI version: 2.5.0

I have done this on (2) different machines running this same version of Windows, with the same result. I have tried multiple versions of MySQL 8.0.x and the two latest versions of PHP.

Any advice?

Downgraded to PHP 7.4.25 and error is no longer happening. Prior to downgrade, I commented out the following line in proc_open_compat in utils.php $cmd = _proc_open_compat_win_env( $cmd, $env ); This also resolved the issue.

Hope this is helpful.

🔨

We’ve got discussions started in the pull requests working on a resolution. In the meantime you may use the Windows fork which has the pull requests pre-merged. https://github.com/lipemat/wp-cli-bundle/releases/tag/2.7.1-windows