woodpecker: Woodpecker 2.4 breaks privileged steps/plugins with Kubernetes backend

This worked with WP 2.3 and Kubernetes backend:

  publish:
    image: woodpeckerci/plugin-docker-buildx
    settings:
      repo: *repo
      tags: 8h

Using WP 2.4 the docker daemon does not start.

Debugging the Pod manifest I see an empty security context and the docker daemon does not start.

This works with WP 2.4.1 but is not so user friendly:

  publish:
    image: woodpeckerci/plugin-docker-buildx
    privileged: true
    backend_options:
      kubernetes:
        securityContext:
          privileged: true
    settings:
      repo: *repo
      tags: 8h
      daemon.debug: "true"

See also: https://github.com/woodpecker-ci/woodpecker/issues/3482#issuecomment-2015672185_

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Reactions: 4
  • Comments: 16 (11 by maintainers)

Most upvoted comments

Regarding the repo setting: Thanks, I was aware of the ‘trusted’ setting. What I wanted to bring up as a possible improvement was to have two settings: One for ‘allow volumes’ and a different one for ‘allow privileged containers’. I always though that mixing these aspects felt a little off as I much more often want to allow volumes than priviliged containers. Kubernetes differentiates these aspects as well.

Then ideally, all checks on pipeline’s stepPrivileged should check trusted repository’s flag instead, I think.

Haven’t had a closer look into this issue yet, but it could definitely be related to https://github.com/woodpecker-ci/woodpecker/pull/3482. We changed the logic in there as we got security request checking this area again as it seemed to be possible to run privileged pods in Kubernetes.