Detox: Regex for Android bundle id causing failures
Using Mac - High Sierra
Description
Line 113 of src/devices/android/ADB.js is:
const bundleIdRegex = pipeCommands.escape.inQuotedRegexp(bundleId) + '[ ]*$';
I’m not sure what the '[ ]*$'
is for, or maybe I’m building my application incorrectly. I’m only able to get detox 9.0.1 to work correctly when I delete the + '[ ]*$'
from that file. I know this is somewhere between and an issue and a question, but can someone clear this up for me.
Sample error: detox[9144] ERROR: [exec.js/EXEC_FAIL, #19] detox[9144] ERROR: [exec.js/EXEC_FAIL, #20] “/Users/me/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell ps | grep “com.myapp.myappportal[ ]*$”” failed with code = 1, stdout and stderr:
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Reactions: 1
- Comments: 17 (1 by maintainers)
Commits related to this issue
- Resolves #924 — committed to wix/Detox by noomorph 6 years ago
@tomatobrown , I’ve found the issue. Your ps output somehow returns ^M line breaks (with DOS endings). I have no slightest idea why but I’ll try to extend the regexp for this case.
Thanks. I’ll look at it first thing tomorrow