Detox: Detox v18/v19 crashes sometimes on iOS in DetoxSync

Description

When updating from v17.latest of Detox to v18.latest I started seeing flakiness in the react-native-firebase e2e tests.

This does not happen all the time, it only happens sometimes. It looks like a bit of a race that some object destruct code is losing sometimes?

• I have tested this issue on the latest Detox release and it still reproduces

Reproduction

Provide the steps necessary to reproduce the issue. If you are seeing a regression, try to provide the last known version where the issue did not reproduce.

1. The react-native-firebase test suite is fully open source - instructions here https://github.com/invertase/react-native-firebase/blob/master/tests/README.md
2. git clone git@github.com:invertase/react-native-firebase.git
3. yarn && yarn tests:ios:pod:install && yarn tests:ios:build
4. In a few terminals: yarn tests:packager:jet and yarn tests:emulator:start and yarn tests:ios:test

Sometimes (not every time, maybe 10% of the time? 20% fo the time?) it will crash with the stack below.

Expected behavior

It rolls through all our tests. For the purposes of this issue, it runs at all 😃 - if it is going to crash, it will do so with no tests passing, if it starts running and a single test passes, they will all roll through It usually crashes at startup but sometimes will make it through a handful of tests first.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

• Detox: v18.22.0
• React Native: 0.66.0-rc.4 (about to be 0.66.0 with no changes)
• Node: v14.17.6
• Device: apple simulator
• Xcode: 12.5.1 (so I can avoid ios15 issues #2895 which are in progress separately)
• iOS: 14.5 (to avoid issues with ios15 #2895)
• macOS: macOS 11.6 (Apple Silicon M1 or Intel Mac - I’ve seen it on both)

Logs

It either works through all tests, or sometime shortly after app launch it crashes like this:

detox[98942] ERROR: [WS_ERROR] The app has crashed, see the details below:

The app has crashed, see the details below:

Signal 11 was raised
(
        0   Detox                               0x00000001104c5a15 +[NSThread(DetoxUtils) dtx_demangledCallStackSymbols] + 37
        1   Detox                               0x00000001104c8e10 __DTXHandleCrash + 464
        2   Detox                               0x00000001104c9555 __DTXHandleSignal + 59
        3   libsystem_platform.dylib            0x00007fff60335d7d _sigtramp + 29
        4   ???                                 0x00007f8fdf920050 0x0 + 140255907938384
        5   CoreFoundation                      0x0000000114170833 -[__NSDictionaryM dealloc] + 128
        6   libobjc.A.dylib                     0x0000000113f3b604 objc_object::sidetable_release(bool, bool) + 174
        7   libobjc.A.dylib                     0x0000000113f378ad _object_remove_assocations + 562
        8   libobjc.A.dylib                     0x0000000113f34c02 objc_destructInstance + 84
        9   libobjc.A.dylib                     0x0000000113f3ad88 -[NSObject dealloc] + 21
        10  libobjc.A.dylib                     0x0000000113f3b604 objc_object::sidetable_release(bool, bool) + 174
        11  CFNetwork                           0x0000000111038610 _CFNetworkHTTPConnectionCacheSetLimit + 162696
        12  CFNetwork                           0x0000000110e81183 CFNetwork + 24963
        13  DetoxSync                           0x0000000146cf0220 ____detox_sync_dispatch_wrapper_block_invoke + 23
        14  libdispatch.dylib                   0x00000001148c370d _dispatch_call_block_and_release + 12
        15  libdispatch.dylib                   0x00000001148c48df _dispatch_client_callout + 8
        16  libdispatch.dylib                   0x00000001148cae15 _dispatch_lane_serial_drain + 715
        17  libdispatch.dylib                   0x00000001148cb9c3 _dispatch_lane_invoke + 455
        18  libdispatch.dylib                   0x00000001148d5f81 _dispatch_workloop_worker_thread + 772
        19  libsystem_pthread.dylib             0x00007fff6034045d _pthread_wqthread + 314
        20  libsystem_pthread.dylib             0x00007fff6033f42f start_wqthread + 15
)

If you are experiencing a timeout in your test

• I have followed the instructions under Identifying which synchronization mechanism causes us to wait too much, I have read synchronization debug documentation and am providing the relevant synchronization debug output below:

If you are seeing a Detox build problem (e.g. during npm install, not detox build)

• I am providing the npm install log below:

Device and verbose Detox logs

• I have run my tests using the --loglevel trace argument and am providing the verbose log below:

Reproducible Demo

In case of a bug or a crash please add an example forking from the DetoxTemplate (follow the guidelines there) which reproduce the issue and ready to clone. Add to the DetoxTemplate (After you fork it), the minimal things which required to reproduce the issue (3rd party libraries / e2e tests).