forgit: [BUG] - FZF not found

Describe the bug I have this in my ~/.zshrc

# fzf & forgit
[ -f ~/.fzf.zsh ] && source ~/.fzf.zsh
which fzf
hash fzf &>/dev/null || echo "hey I am working!"
[ -f ~/.forgit/forgit.plugin.zsh ] && source ~/.forgit/forgit.plugin.zsh

but when I restart my terminal here is the outpout:

/home/zezen/.fzf/bin/fzf
hey I am working!
[Warn] FZF not found and is requried for forgit

To Reproduce I don’t see anything I could have done wrong …

Expected behavior That it works (as they say)

Screenshots

Desktop (please complete the following information):

Operating System: elementary OS 5.0 Juno
          Kernel: Linux 4.15.0-70-generic
    Architecture: x86-64

Shell: zsh
Shell Version: zsh 5.4.2 (x86_64-ubuntu-linux-gnu)
Any other terminal config? antigen in zsh but not using it for fzf or forgit

About this issue

Original URL
State: closed
Created 5 years ago
Comments: 21 (14 by maintainers)

Commits related to this issue

fix: 🐛 No necessary to check if fzf exists during loading. #57 — committed to wfxr/forgit by wfxr 5 years ago

Most upvoted comments

Wow, thanks! just went from this:

to this:

and it is now working well!

so maybe the readme has to be clearer about this: load fzf before zsh, but load forgit after it

I’ll close the issue since that fixed mine 😃

benavern on Nov 22, 2019

How did you fix it ? could you share your configuration files ? I didn’t manage to make it work yet …

The thing is forgit.plugin.zsh executes hash fzf &>/dev/null and before it does it you need to have fzf in your $PATH.

I am using oh-my-zsh to load plugins and this is my .zshrc: https://github.com/horseinthesky/dotfiles/blob/master/files/.zshrc

You can see I firstly do: https://github.com/horseinthesky/dotfiles/blob/7b098009bc5e1ae7b675ddd2443c105d55de60fe/files/.zshrc#L54

And then I load the plugins: https://github.com/horseinthesky/dotfiles/blob/7b098009bc5e1ae7b675ddd2443c105d55de60fe/files/.zshrc#L116

horseinthesky on Nov 22, 2019