webpack-subresource-integrity: Broken on Windows
We integrated this plugin into Create React App (https://github.com/facebookincubator/create-react-app/issues/1202), and the build breaks on Windows:
To reproduce:
npm i -g create-react-app
create-react-app myapp --scripts-version 0.8.2
cd myapp
npm run build
This happens on Windows because the generated compilation assets key contains Windows path separators but Webpack expected a normalized one.
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Comments: 15 (2 by maintainers)
Commits related to this issue
- Add failing tests (WIP) Closes #22 — committed to waysact/webpack-subresource-integrity by jscheid 7 years ago
- Add failing tests (WIP) Closes #22 — committed to waysact/webpack-subresource-integrity by jscheid 7 years ago
- More robust path matching When there is no direct match for an asset path, search for it by comparing normalized paths where the query part is stripped and (on Windows) backslashes are replaced by fo... — committed to waysact/webpack-subresource-integrity by jscheid 7 years ago
Wow cool now it is part of create react app? 😃
Yea!
Ah, good to know, but I’d call this a workaround and not a fix. I’m aiming to release a fix for this soon and you’ll be able to go back to using
path.join.