vueuse: [Bug report] computedWithControl is triggering "Computed is still dirty after getter evaluation" warning

BTW, it’s not suggested to directly reply under a closed issue, you can create a new one next time.

You can extract the useStorage outside the getters like on the top of the file, and use the return value in the getters.

  const isLoggedInRef = useStorage('isLoggedIn')
  ...
  getters: {
    isLoggedIn: () => isLoggedInRef.value
  }

In fact, getters in Pinia is a computed as well, so it will cause that warning.

I see, what’s the approach to resolve this warning?

At least in my side, I believe returning a computedWithControl could be a bad thing for users, just take the useActiveElement as example, we can definitely return a standard computed so that users can generate other state with computed.😉 Can this be considered, and do you think a full check in all apis is helpful?

I think mark this function is not a computed will be helpful, thanks for your suggestions!

I suggest not closing this issue too casually. it’s weird to say:

computedWithControl is not a computed under the hood.

Then why a name with computedWithControl? There are people reporting the same problem with VueUse functions (see https://github.com/vueuse/vueuse/issues/3774#issuecomment-1945839213). I don’t think add a warning somewhere in computedWithControl docs helps.

I would suggest one of the 2 things which should really solve the issue:

• try to make computedWithControl work with Vue 3.4 new reactivity system
• deprecate computedWithControl and any other api with /** @deprecated */ which may confuse the users, and give them new name to better describe them and maybe warnings in jsdocs too.

As long as computedWithControl and things like this is returned in any VueUse functions, then it will probably be misused in user cases. You can not expect users to special handle them.

cc @Doctor-wu