core: Incorrect vite warning regarding nesting tr directly in table element
Vue version
3.5.10
Link to minimal reproduction
Steps to reproduce
Create a SFC with this content.
<template>
<table>
<tr></tr>
</table>
</template>
Vite will issue a warning:
warning: <tr> cannot be child of <table>, according to HTML specifications. This can cause hydration errors or potentially disrupt future functionality.
This warning is factually incorrect. The relevant spec says that a <table> may contain:
In this order: optionally a caption element, followed by zero or more colgroup elements, followed optionally by a thead element, followed by either zero or more tbody elements or one or more tr elements, followed optionally by a tfoot element, optionally intermixed with one or more script-supporting elements.
This is because htmlNesting.ts does not list tr as a valid child of table, despite the spec allowing it.
What is expected?
I expect no warning to be produced.
What is actually happening?
A warning is produced from vite:
warning: <tr> cannot be child of <table>, according to HTML specifications. This can cause hydration errors or potentially disrupt future functionality.
System Info
+-- @vitejs/plugin-vue-jsx@3.1.0
+-- @vitejs/plugin-vue@5.0.4
+-- @vue/tsconfig@0.4.0
+-- vite@5.4.8
+-- vue-tsc@2.1.6
`-- vue@3.5.10
About this issue
- Original URL
- State: open
- Created 2 years ago
- Reactions: 30
- Comments: 18 (6 by maintainers)
Commits related to this issue
- dx(compiler-dom): move ssr specific template warning to compiler-ssr (fix #12088) — committed to aelgn/vuejs-core by aelgn 2 years ago
Can't really expect everyone to change all table based components to an optional html syntax or lose functionality of the console.i agree with @aelgn - i dont think this is an edge case and, since this is optional html syntax, it makes it harder to debug actual errors
I’m seeing my stdout absolutely brim-filled with this warning and its accompanying template print out in both dev and build environments, to a point that it swallows and obscures any legitimate warnings. I do not use SSR so I’m not impacted by the discrepancy between the hydration feature implementation and the html specification.
Could this warning be predicated by SSR actually being used? Or could we disable this warning in any way? (except writing a custom vite logger to filter it out) If not I think this warning should be removed. Can’t really expect everyone to change all table based components to an optional html syntax or lose functionality of the console.
I see that this issue is labeled as an edge-case, my vote is that it is not.
At a minimum the warning shouldn’t claim that this is due to a spec. It seems this is constraint introduced by the implementation details of hydration. It could say something like this.
Personally, I’m not using SSR at all, so then I would know it’s perfectly safe to ignore this warning.
For a Vue newbie, this was very confusing. Seeing something that is obviously valid HTML get flagged as an error/warning does not help me advance in my Vue knowledge. It is good that I stumbled across this thread. Thanks for fixing this in the future.
That quote is regarding the document object, not the markup. The parenthesized part explicitly explains the relationship between the markup and the document object.
If you don’t believe me, you can use the WHATWG’s own validator service, which shows no errors or warnings for direct nesting of
<tr>in<table>.Agreed. But this isn’t invalid. I’ve quoted the relevant spec.
True. But at least the error message doesn’t claim that it’s because it’s invalid, just that it breaks Svelte’s assumptions. My preference would be that the warning was removable by default or configuration. But I’d settle for a message worded like svelte’s, which makes it clear that the constraint is based on vue’s implementation details.
Update… I just spent the time to modify source to always use either thead or tbody or both. I had maybe a dozen cases in which I was not using the optional node. So now I guess I’m on team tbody. Moooving on.
I see the same thing. Fix the warning or provide a work around?
I’d suggest making the check more flexible, as it’s not very comprehensive at the moment.
Technically, that same spec says this too:
https://html.spec.whatwg.org/multipage/syntax.html#element-restrictions
Also, even if someone is not using SSR, they shouldn’t be writing invalid HTML. This particular case of tr inside table doesn’t affect non-SSR users, but other cases should keep showing warnings.
Svelte also throws similar error:
Can there be some additional smarts going on, such that this warning only displays if there is a mismatch detected between SSR and CSR?
Alternatively, Vue should not be adding
nodes because the browser is fine with no such node being present. Perhaps that’s the real problem, that Vue should not be doing this at all?I don’t think this is showing what you think it is showing.
This is a serialized DOM. In HTML,
<tbody>is explicitly optional, by specification, as I’ve cited above.