parcel-plugin-custom-dist-structure: Maximum call stack size exceeded
Hi! Just giving the plugin a spin against a project I’m working on and I get the following error when I run with the plugin installed:
Server running at http://localhost:1234
√ Built in 20.18s.
× Maximum call stack size exceeded
at Map.entries (<anonymous>)
at Function.from (<anonymous>)
at DependencyGraph.buildDependencyAssets (C:\MyProject\Publish\node_modules\parcel-plugin-custom-dist-structure\lib\DependencyGraph.js:51:36)
at C:\MyProject\Publish\node_modules\parcel-plugin-custom-dist-structure\lib\DependencyGraph.js:62:14
at Array.forEach (<anonymous>)
at DependencyGraph.buildDependencyAssets (C:\MyProject\Publish\node_modules\parcel-plugin-custom-dist-structure\lib\DependencyGraph.js:53:22)
at C:\MyProject\Publish\node_modules\parcel-plugin-custom-dist-structure\lib\DependencyGraph.js:62:14
at Array.forEach (<anonymous>)
at DependencyGraph.buildDependencyAssets (C:\MyProject\Publish\node_modules\parcel-plugin-custom-dist-structure\lib\DependencyGraph.js:53:22)
at C:\MyProject\Publish\node_modules\parcel-plugin-custom-dist-structure\lib\DependencyGraph.js:62:14
The project has around 800 html & image files.
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 15 (9 by maintainers)
Commits related to this issue
- FIX: buildDependencyAssets() stack overflow On bigger projects (800+ files) buildDependecyAssets() function would cause plugin to crash. It would eat all memory because of it's recursive design patte... — committed to VladimirMikulic/parcel-plugin-custom-dist-structure by VladimirMikulic 4 years ago
- FIX: buildDependencyAssets() stack overflow On bigger projects (800+ files) buildDependecyAssets() function would cause plugin to crash. It would eat all memory because of it's recursive design patte... — committed to VladimirMikulic/parcel-plugin-custom-dist-structure by VladimirMikulic 4 years ago
- FIX: buildDependencyAssets() stack overflow On bigger projects (800+ files) buildDependecyAssets() function would cause plugin to crash. It would eat all memory because of it's recursive design patte... — committed to VladimirMikulic/parcel-plugin-custom-dist-structure by VladimirMikulic 4 years ago
- FIX: buildDependencyAssets() stack overflow On bigger projects (800+ files) buildDependecyAssets() function would cause plugin to crash. It would eat all memory because of it's recursive design patte... — committed to VladimirMikulic/parcel-plugin-custom-dist-structure by VladimirMikulic 4 years ago
v1.1.5 has been released! Thank you for your help. Now, the plugin is ready for enterprise projects 😎
That’s awesome to hear. I’ll leave the issue and PR open for 2 more days to be sure that this does work flawlessly on bigger projects and after that, I’ll merge the PR and publish a new version to NPM.
W00t! That seems to have worked! Thanks very much. I’ll enable it while I’m continuing to develop and see if it’s stable… or if I can find any edge cases.
So far so good. At least I’ve eliminated one option. I’ve updated the branch, could you please follow the steps again and see if this fixed the issue?
Thank you.
@HowardvanRooijen I might not even need it. I think I’ve fixed it, but I’ll need your help to verify this 😃
I would like you to test it, the steps are:
git clone https://github.com/VladimirMikulic/parcel-plugin-custom-dist-structure.git
git checkout fix/build-dependency-assets-stack-overflow
npm link
Thank you.