vitest: Crashes under Windows

Describe the bug

Adding this here so we don’t forget to fix it

Reproduction

https://github.com/vitest-dev/vitest/runs/4868391749?check_suite_focus=true

System Info

Windows

Used Package Manager

pnpm

Validations

Follow our Code of Conduct
Read the Contributing Guidelines.
Read the docs.
Check that there isn’t already an issue that reports the same bug to avoid creating a duplicate.
Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
The provided reproduction is a minimal reproducible example of the bug.

About this issue

Original URL
State: closed
Created 2 years ago
Comments: 27 (27 by maintainers)

Commits related to this issue

fix: fix node crash under Windows (fix #582) (#588) * fix: fix node crash under Windows * chore: use exit code 1 if cli did not exit in time * Revert "chore: use exit code 1 if cli did not exit... — committed to vitest-dev/vitest by Demivan 2 years ago

Most upvoted comments

All five attempts are passing https://github.com/vitest-dev/vitest/actions/runs/1718747096

sheremet-va on Jan 19, 2022

Too soon

sheremet-va on Jan 19, 2022

@Demivan @sheremet-va the changes on #588 works on my windows machine, no error reported

userquin on Jan 19, 2022

Problem right now is that this.close promise resolves, and that resolves Promise.race so we call process.exit() but not everything was cleaned up.

We should call process.exit() only if Vitest locked up somewhere and needs to be killed.

Demivan on Jan 19, 2022