vite: Wrong esbuild target when using `vite dev`
Describe the bug
When setting a build target in the config using either build.target or esbuild.target, this only applies to vite build. So far, this is expected, since #10207 automatically sets the esbuild target to esnext when using vite dev. However, when I import a library that requires the target to be set to esnext (bson for example) and try running vite dev I get this error message:
[ERROR] Top-level await is not available in the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari14" + 2 overrides)
Running vite build works fine. So I am wondering, why the target environment during vite dev is set to the default target instead of esnext.
Reproduction
https://stackblitz.com/edit/vitejs-vite-rfowdk?file=main.js
Steps to reproduce
- Running
vite buildsucceeds - Running
vite devfails
System Info
System:
OS: Linux 5.0 undefined
CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 0 Bytes / 0 Bytes
Shell: 1.0 - /bin/jsh
Binaries:
Node: 16.20.0 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 9.4.2 - /usr/local/bin/npm
pnpm: 8.6.3 - /usr/local/bin/pnpm
npmPackages:
vite: ^4.4.0 => 4.4.2
Used Package Manager
npm
Logs
No response
Validations
- Follow our Code of Conduct
- Read the Contributing Guidelines.
- Read the docs.
- Check that there isn’t already an issue that reports the same bug to avoid creating a duplicate.
- Make sure this is a Vite issue and not a framework-specific issue. For example, if it’s a Vue SFC related bug, it should likely be reported to vuejs/core instead.
- Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
- The provided reproduction is a minimal reproducible example of the bug.
About this issue
- Original URL
- State: open
- Created 3 years ago
- Reactions: 7
- Comments: 18 (7 by maintainers)
Glad to answer your questions.
Vite use esbuild to pre-bundle dependencies in node_modules. For pre-bundle stage, optimizeDeps.esbuildOptions is used as transform api’s parameter. You can try it.
https://github.com/vitejs/vite/blob/c8a741adec14568f2ba9599056cb2eebab52215f/packages/vite/src/node/optimizer/index.ts#L809
I just tried it, and it work. https://github.com/haijie-x/vite-issues/tree/master/esbuild-target
Not sure if I misunderstood you, but I hope this can help you.
So as far as I understand, this is how the target is determined for the different parts:
vite devesnextautomaticallyoptimizeDeps.esbuildOptions.targetvite buildbuild.targetbuild.targetI find this quite confusing, honestly. IMO everything should be affected by
build.target. Maybe it could be overridden byoptimizeDeps.esbuildOptions.target, but the default value should be the one frombuild.targetand not the global default. Is there any specific reason for how it’s implemented currently?@bluwy I may be misunderstanding something, but I’m not sure if separating the targets for build vs dev is a good default behavior. I could see it being a useful opt-in behavior if it’s explicitly set. With the exception of minification, I expect (or hope) my code will have the same output in both scenarios because debugging/fixing something is much more difficult if it is built for a different environment.
Inability to override the default
targetfor development mode makes it impossible to use Vite withesbuildin projects which use the stage 3 decorators, because the bundler does not transpile them when target isesnext. The solution may be to use the@rollup/plugin-typescriptas a replacement foresbuild, but in that case all dependencies are managed bytypescriptas well. Either way it’s a loss.You can set
esbuild.target: "es2020"oresbuild.supported.decorators: false(see https://github.com/vitejs/vite/issues/17308) to get it to work. If you want to use decorators in JS too, you need to configure esbuild to process JS files too withesbuild.include. You don’t need an external plugin for this.What is the recommended way to target older versions of a browser for development/debugging purposes? I’ve tried setting the three different target parameters but none of them seem to be working to change the target of what the NPM dependencies are transformed to.
@bluwy looks like that works, thank you! I am curious though… shouldn’t the build be picking up my tsconfig target? it seems a little odd and unfortunate to need to define the build target in multiple places.