astro: Trailing slash resolves in 404
Hi,
The pwa works great but I would like to know how to redirect
/blog/post/ to blog/post trailing slashes in the url are not resolving.
It is a static build
build: {
format: "file"
},
AstroPWA({
mode: "production",
base: "/",
scope: "/",
includeAssets: [`icons/${process.env.THEME}/favicon.svg`],
registerType: "autoUpdate",
manifest: manifest,
workbox: {
navigateFallback: "/404",
globPatterns: ["**/*.{js,css,html,txt,json,svg,woff,woff2,ico,xml}"],
},
devOptions: {
enabled: false,
navigateFallbackAllowlist: [/^\/404$/],
},
}),
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 31 (18 by maintainers)
@userquin thanks for the release! I am now using the new flag and it works 😃
@felixroos can you run the same process with the branch in this PR in you GH repro and deploy to GH Pages?
userquin/feat-experimental-trailing-slashes-handlerbranchpnpm install && pnpm build && pnpm packpnpm remove -D @vite-pwa/astrothen removevite-pwa-astro-0.1.3.tgzfilepnpm add -D ./vite-pwa-astro-0.1.3.tgzpnpm build && pnpm previewand check it is workingI’m preparing the docs, the experimental option added in VitePress cannot be added, Astro will clone the PWA options and cannot be referenced, it will require a change in
vite-plugin-pwa.I can see what I can do, please give yourself some rest. I can also wait or use the tgz
I’m not sure as I have too little knowledge of this project to give my opinion on it. Of course, having less config options is always a plus, but maybe the old behavior is sometimes desired, not sure. From my perspective this looks more like a bug that should probably be fixed by default, but maybe it introduces some regression. Maybe start with the feature flag and test it with a handful of existing projects to see if it has downsides? Either way, I would be very happy to be able to use this as it will finally fix this annoying bug I was having for some time now.
done: https://felixroos.github.io/astro-test-pwa/ works!
https://felixroos.github.io/astro-test-pwa/ now deployed with autoUpdate + menu
On first sight that sounds like it would help in this case!
Thanks!
For completeness sake, I’ve now done a full reproduction that shows how adding @vite-pwa/astro to the mix results in wrong caching behavior:
I Will try to check your repro tmr.
I have done a quick test repro with a simple astro project that builds using
build.format: 'directory': https://github.com/felixroos/astro-test/Both of these urls work:
So it seems the problem is really service worker related…
Just found: https://github.com/slorber/trailing-slash-guide which explains the behavior of github pages for different links, notably:
/file - ✅ /file/ - 💢 404 /folder - ➡️ /folder/ /folder/ - ✅
This further confirms that
build.format: 'file'will cause a 404 with a trailing slash. Without using a service worker, it looks like it would work withbuild.format: 'directory', as it will just do a redirect. So is suspect that the service worker will interpret urls without trailing slashes as a file and for some reason serve the root file.