violentmonkey: [BUG] `page` injection mode stopped working after updating to v2.13.5
-
The bug is also present in the latest beta. Warning! Do an export in Violentmonkey settings before testing.
-
I have searched for existing issues that already reported this problem and found none
Describe the bug
Scripts cannot be injected with the page injection mode after updating to v2.13.5. All scripts were being injected using the content mode, while setting the mode to page manually would make all scripts fail to inject to the webpage, even when the CSP of the page allowed such injection.
To Reproduce Note that issues without a reproduction may be closed immediately! Steps to reproduce the behavior:
- Update the extension to v2.13.5
- Set the injection mode to
page - Scripts failed to be injected
Expected behavior
Scripts being injected in the page mode.
Actual behavior Scripts didn’t inject into the page at all.
Environment:
- OS: Windows 10
- Browser: Firefox
- Browser Version: 109.0b6
- Violentmonkey Version: v2.13.5
About this issue
- Original URL
- State: closed
- Created a year ago
- Reactions: 3
- Comments: 17 (12 by maintainers)
Commits related to this issue
- fix: set wantsPage in FF properly for realz fixes #1708 — committed to violentmonkey/violentmonkey by tophf a year ago
Yeah that’s doable but it makes the testing process unnecessarily complicated, and makes it not possible for beta testers to run the beta version as their daily-driver to catch any bug in advance. I think we could have a signed beta version which is a bit ahead of the stable version just for our beta testers to catch bugs in advance, and release stable versions after several days of testing. Also, for this issue I think it’s better to just publish the latest stable version on AMO asap.
@gera2ld, this is pretty bad because it breaks scripts that override various stuff in page context so I’d say we should make a new release sooner this time, the sooner the better… I’m assuming we can’t just set the previous version as current on AMO.
I’ve added a link to beta in our listing on AMO, hopefully it’ll attract more testers.