objection.js: QueryBuilder.relate() and .patch() yield the wrong type

The typings have the relate() method of QueryBuilder returning type this and thus yielding a Model. However, relate() actually yields either a numberor an object pairing IDs to their corresponding reference fields. I don’t know what the result is when providing multiple relations.

UPDATE: QueryBuilder patch() has the same problem – should yield a number.

cc @mceachen

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 23 (9 by maintainers)

Most upvoted comments

By the way, have you talked this refactoring through with @mceachen?

I hear from him once every day or two, which isn’t enough interaction for me to get this done. So I’m just doing it and he can look it over.

jtlapp on Jan 21, 2018

Maybe a separate issue should be opened for this

koskimas on Jan 21, 2018

Query callbacks that don’t need to return anything:

modifyEager
where callbacks
select callbacks
from callbacks

Actually all subquery or where grouping callbacks don’t need to return anything and the return value and query builder return type are irrelevant.

If there are other callbacks, ask.

koskimas on Jan 21, 2018

For now you can work around this by adding the patch or relate last. relate typings cannot be fixed, an you need to use a cast.

koskimas on Jan 14, 2018