objection.js: A problem with typescript version 4

Hi! Same as @Linksku, I also need to wrap the declaration of PartialModelGraph with T extends any ? ... : never. If I don’t do this, the types of “nested” models (from relationMappings) in a model graph are not inferred by TypeScript. However, I do not face a Maximum call stack size exceeded error when compiling my project without this fix:

type PartialModelGraph<M, T = M & GraphParameters> = T extends any ? {
    [K in DataPropertyNames<T>]?: Defined<T[K]> extends Model
      ? PartialModelGraph<Defined<T[K]>>
      : Defined<T[K]> extends Array<infer I>
      ? I extends Model
        ? PartialModelGraph<I>[]
        : Expression<T[K]>
      : Expression<T[K]>;
  } : never;

@koskimas: Cloud you release a new version with the T extends any ? ... : never fix? I would be very grateful! 😃

FYI: It does not matter if I set strict: true or strict: false in my tsconfig.json file - in both cases, I still need the T extends any ? ... : never fix.

Package versions:

typescript: 4.5.4
objection: 3.0.1
knex: 0.95.15

I’m running into this issue with the released version of 3.0.0

@koskimas are you saying that objection 3 requires strict: true to work properly with typescript? Is that documented anywhere? It seems like a pretty significant limitation.

Hi, I have the same issue. Also fixed with the T extends any ? ... : never fix. Please can you release a new version with this included?

I am getting the same error on Typescript 4.5.5 as well. I was able to get rid of the problem by setting strictNullChecks: false in tsconfig.json as mentioned in related issue but it’s just a temporary fix.

@koskimas I think the issue is caused by NonFunctionPropertyNames including QueryBuilderType. It should go away by excluding QueryBuilderType in PartialModelObject and PartialModelGraph:

  type PartialModelObject<T extends Model> = {
    [K in Exclude<NonFunctionPropertyNames<T>, 'QueryBuilderType'>]?: Defined<T[K]> extends Model
      ? T[K]
      : Defined<T[K]> extends Array<infer I>
      ? I extends Model
        ? I[]
        : Expression<T[K]>
      : Expression<T[K]>;
  };

I’m not sure why I also needed T extends any for PartialModelGraph, probably some weird union issue:

  type PartialModelGraph<M, T = M & GraphParameters> = T extends any ? {
    [K in Exclude<NonFunctionPropertyNames<T>, 'QueryBuilderType'>]?: Defined<T[K]> extends Model
      ? PartialModelGraph<Defined<T[K]>>
      : Defined<T[K]> extends Array<infer I>
      ? I extends Model
        ? PartialModelGraph<I>[]
        : Expression<T[K]>
      : Expression<T[K]>;
  } : never;

I don’t think strict is required, but it will point out any errors in your model files. In my case the solution was to properly define the properties with the ! operator, e.g. id!: string

Edit: Actually, strict is required for compilation.

Reproduction: https://github.com/stefanvanherwijnen/objection-repro-2132