vime: Not working with Angular 9

I’m using Angular V9.1.11, and i tried to use the latest version of vime but it gives an error as you can see below :

Compiling @vime/angular : module as esm5 Warning: Invalid constructor parameter decorator in D:/Projects/My Project/My-Project/node_modules/@vime/angular/dist/fesm2015/vime-angular.js: () => [ { type: ChangeDetectorRef }, { type: ElementRef }, { type: NgZone } ] Error: Error on worker #1: Error: getInternalNameOfClass() called on a non-ES5 class: expected VimeAudio to have an inner class declaration at Esm5ReflectionHost.getInternalNameOfClass (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\ngcc\src\host\esm5_host.js:88:23) at DelegatingReflectionHost.getInternalNameOfClass (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\ngcc\src\host\delegating_host.js:89:34) at Object.extractDirectiveMetadata (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\src\ngtsc\annotations\src\directive.js:237:69) at ComponentDecoratorHandler.analyze (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\src\ngtsc\annotations\src\component.js:143:47) at NgccTraitCompiler.TraitCompiler.analyzeTrait (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\src\ngtsc\transform\src\compilation.js:345:40) at analyze (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\src\ngtsc\transform\src\compilation.js:297:58) at _loop_1 (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\src\ngtsc\transform\src\compilation.js:319:21) at NgccTraitCompiler.TraitCompiler.analyzeClass (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\src\ngtsc\transform\src\compilation.js:325:35) at NgccTraitCompiler.analyzeFile (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\ngcc\src\analysis\ngcc_trait_compiler.js:47:26) at DecorationAnalyzer.analyzeProgram (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\ngcc\src\analysis\decoration_analyzer.js:134:39) at ClusterMaster.onWorkerMessage (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\ngcc\src\execution\cluster\master.js:194:27) at D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\ngcc\src\execution\cluster\master.js:54:95 at ClusterMaster.<anonymous> (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\ngcc\src\execution\cluster\master.js:292:57) at step (D:\Projects\My Project\My-Project\node_modules\tslib\tslib.js:140:27) at Object.next (D:\Projects\My Project\My-Project\node_modules\tslib\tslib.js:121:57) at D:\Projects\My Project\My-Project\node_modules\tslib\tslib.js:114:75 at new Promise (<anonymous>) at Object.__awaiter (D:\Projects\My Project\My-Project\node_modules\tslib\tslib.js:110:16) at EventEmitter.<anonymous> (D:\Projects\My Project\My-Project\node_modules@angular\compiler-cli\ngcc\src\execution\cluster\master.js:286:32) at EventEmitter.emit (events.js:314:20) An unhandled exception occurred: NGCC failed. See “C:\Users\saber\AppData\Local\Temp\ng-KmWmwL\angular-errors.log” for further details. npm ERR! code ELIFECYCLE npm ERR! syscall spawn npm ERR! file C:\Windows\system32\cmd.exe npm ERR! errno ENOENT npm ERR! angular-electron@7.2.1 ng:serve: ng serve npm ERR! spawn ENOENT npm ERR! npm ERR! Failed at the angular-electron@7.2.1 ng:serve script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\saber\AppData\Roaming\npm-cache_logs\2020-11-30T14_36_06_880Z-debug.log ERROR: “ng:serve” exited with 1. npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! angular-electron@7.2.1 start: npm-run-all -p electron:serve ng:serve npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the angular-electron@7.2.1 start script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\saber\AppData\Roaming\npm-cache_logs\2020-11-30T14_36_06_999Z-debug.log

I’ve tried version 4.2.2 just to see if things gonna work, but nothing

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 15 (6 by maintainers)

Commits related to this issue

fix(angular): not working in production ref #124 — committed to vime-js/vime by mihar-22 4 years ago
fix(angular): add for support angular 9/10 ref #124 — committed to vime-js/vime by mihar-22 4 years ago

Most upvoted comments

up and running, thx very much 😃

michalhornak22 on Dec 21, 2020

Okay I’m going to revert 5.0.17, seems useless. Really glad it’s all working now 😄

mihar-22 on Dec 21, 2020

on 5.0.16 still get these warnings

npm WARN @vime/angular @5.0.16 requires a peer of @angular/common@^11.0.4 but none is installed. You must install peer dependencies yourself. npm WARN @vime/angular @5.0.16 requires a peer of @angular/core@^11.0.4 but none is installed. You must install peer dependencies yourself. npm WARN @vime/angular @5.0.16 requires a peer of rxjs@^6.6.2 but none is installed. You must install peer dependencies yourself.

and this on build

Warning: Entry point ‘@vime/angular’ contains deep imports into ‘…@vime/core/dist/types’. This is probably not a problem, but may cause the compilation of entry points to be out of order.

But … otherwise AWESOME working with angular 9.1.0 - prod build - that was using 5.0.16

Thank you

jnurse13 on Dec 21, 2020

I tested it with 5.0.14 and 5.0.15 on angular 10 example https://github.com/vime-js/vime/tree/master/examples/angular but with no change…

michalhornak22 on Dec 21, 2020

i have tried same thing with your angular example https://github.com/vime-js/vime/tree/master/examples/angular. with ng serve everything works fine, but ng serve --prod has same problem as my app…

michalhornak22 on Dec 19, 2020

I have similar issue with angular 10, my prod build runs allright, but all vime videos in prod builds or prod serve wont work…but in dev build everything works fine…i have used v 4.7.3 which worked all right until few days ago, Im guessing it could also be some chrome update which started doing this error, because the same error is on 4.7.3 and also on all v5 versions… you can see my usage of vime videos here: http://ikony-doc.michalhornak.me/#/chapter1 there is no height on videos and if you click play it crashes…I tried to use last week versioin of my app which worked 100% and still not working now…

Capture

michalhornak22 on Dec 19, 2020

Ah damn. Okay it’s no problem because I’ll be building a proper development workflow for testing framework integrations after the weekend (first thing Monday, Saturday now). I’ll spot all the bugs and fix it up then.

mihar-22 on Dec 18, 2020