vike: TypeError [ERR_INVALID_STATE]: Controller is already closed in vike@0.4.227 during streaming in production
Description
Sometimes production server fails with this error, it is marked with vike bug label Error: [vike@0.4.227][Bug]. It was also happening with v0.4.226
TypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closed
--
at ReadableStreamDefaultController.enqueue (node:internal/webstreams/readablestream:1070:13)
at Object.writeChunk (file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:559:33)
at file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:329:37
at Array.forEach (<anonymous>)
at flushBuffer (file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:328:16)
at writeStream (file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:322:9)
at onEnd (file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:293:21)
at async closeStream (file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:527:13)
at async onEnd (file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:544:25)
at async handleReadableWeb (file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:627:5) {
code: 'ERR_INVALID_STATE'
}
node:internal/process/promises:391
triggerUncaughtException(err, true /* fromPromise */);
^
Error: [vike@0.4.227][Bug] You stumbled upon a Vike bug. Go to https://github.com/vikejs/vike/issues/new?template=bug.yml and copy-paste this error. A maintainer will fix the bug (usually within 24 hours).
at onEnd (file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:306:21)
at async closeStream (file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:527:13)
at async onEnd (file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:544:25)
at async handleReadableWeb (file:///app/node_modules/.pnpm/vike@0.4.227_react-streaming@0.4.2_react-dom@19.1.0_react@19.1.0__react@19.1.0__vite@6.2.4_@t_krcihacrr6hdjx57jnk4gb3oxy/node_modules/vike/dist/esm/node/runtime/html/stream.js:627:5)
Node.js v20.19.0
ELIFECYCLE Command failed with exit code 1.
vike: 0.4.227
node: 20.19.0
vike-server: 1.0.12
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 23 (17 by maintainers)
Commits related to this issue
- fix: further ensure data isn't written after stream is closed (fix #2334) — committed to vikejs/vike by brillout 2 years ago
I added Dockerfile to the main branch, so you have the same environment. Tested in all major browsers (chrome, safari, zen(firefox)), same result.
Screencast with docker and all browsers: https://drive.google.com/file/d/1u8yFlAXagHksZQnzNAerIPJqzpP-4Ozk/view?usp=sharing
Sometimes it goes down really fast, sometimes it takes more time.
Node js version in docker v20.19.0 On my machine I was using also v20 and later v22.14.0
Fix pre-released as
0.4.227-commit-45216bc. I ain’t sure but I guess this solves the issue. Let me know if it doesn’t and I’ll re-open.