turborepo: [turborepo] regression on handling SIGINT
What version of Turborepo are you using?
1.7.4
What package manager are you using / does the bug impact?
npm
What operating system are you using?
Linux
Describe the Bug
Referring to #444 and its implementation on #663, it looks like there was a behavioural regression introduced in 1.7.0 where SIGINT is no longer handled properly. The last working version was 1.6.3.
The bug is related to the fact that when interrupting a program (^C), turbo doesn’t wait for the program to handle the SIGINT command and immediately terminates the process.
It is worth noting that the SIGINT instruction continues to run in the background, and the terminal becomes interactive again. This poses a problem when running turbo from a Docker container, for example, while Docker waits for the SIGINT instruction to be handled and then kills the container process. Since turbo doesn’t wait for SIGINT to complete, docker simply kills the process prematurely. The expected behaviour here would be that of 1.6.3.
Expected Behavior
Turbo should wait for the program to handle the SIGINT instruction and only then exit the running process.
To Reproduce
./apps/bar/package.json
{
"name": "@foo/bar",
"scripts": {
"start": "trap 'echo wait…; sleep 3; echo done!; exit 0' SIGINT; sleep 10",
}
}
turbo@1.6.3 (expected behaviour)
$ npx turbo run start --filter=@foo/bar --only
• Packages in scope: @foo/bar
• Running start in 1 packages
• Remote caching disabled
@foo/bar:start: cache miss, executing a0c8f8ecc5ad4cad
@foo/bar:start:
@foo/bar:start: > start
@foo/bar:start: > trap 'echo wait…; sleep 3; echo done!; exit 0' SIGINT; sleep 10
@foo/bar:start:
^C@foo/bar:start: wait… # <<< SIGINT
@foo/bar:start: done!
$ echo interactive again....
turbo@1.7.0 (unexpected behaviour)
$ npx turbo run start --filter=@foo/bar --only
• Packages in scope: @foo/bar
• Running start in 1 packages
• Remote caching disabled
@foo/bar:start: cache miss, executing 52f6ea6626d6482f
@foo/bar:start:
@foo/bar:start: > start
@foo/bar:start: > trap 'echo wait…; sleep 3; echo done!; exit 0' SIGINT; sleep 10
@foo/bar:start:
^C@foo/bar:start: wait… # <<< SIGINT
$ echo interactive again
interactive again
$ @foo/bar:start: done! # <<< bg process
Reproduction Repo
No response
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Reactions: 34
- Comments: 28 (9 by maintainers)
Is this working or will be fixed anytime soon? I’m having some issues that docker doesn’t close when I do
Ctrl + C. I’m usingpnpmand graceful teardown works usingpnpm --filter=mypackage run devbutnpx turbo run dev --filter=mypackagefails to teardown all child processes.@notaphplover I had some time to delve into this and this is a larger feature request. We currently always exit with exit code 1 if we receive a signal. In order to return the highest exit code we need to start gracefully handling signals where the first
SIGINTwe receive gets forwarded to the child processes and then if we receive anotherSIGINTwe sent aSIGKILL.I don’t expect this work will get done until we finish porting the codebase to Rust. Hopefully as we port this signal code we can set the groundwork for being more graceful with our signal handling.
Seeing same issue where docker fails to teardown when using turbo
2.1.2.Experiencing the same issue,
turbo version 1.13.3; when I hit ctrl+c I get anERROR run failed: command exited (1). That doesn’t happen when I run a command with a single task from root directory and use interactive mode, but when I disableinteractiveor when there is more than one task I get that error. Oh, and I’m usingnpm! 😃Update: Same with
turbo@1.9.1:Hey, @Scalahansolo, I was only removing one of our workstream automations. We don’t need to mark Issues as owned by a specific team anymore since Turbopack is no longer in this repository.
We’re still working through fixes and features as usual. If you want to express your interest for this Issue, you can help us prioritize by adding your 👍 to the top-level if you haven’t yet. Thanks!
Not a great first impression using turborepo only to find out that we… can’t trap exit codes… since February 2023? lol
Same here in turbo
2.2.3We are observing same issue 😦