updatecli: Multiple targets with automated signed commits for GitHub Actions creates duplicate commits
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
When using the commitapi set to true with a manifest like this one https://github.com/olblak/kubernetes-marketplace/blob/master/.github/updatecli/updatecli.d/kubewarden.yaml
Updatecli creates duplicate commits where each Updatecli run even though all duplicated commits looks valid For example this pullrequest https://github.com/olblak/kubernetes-marketplace/pull/118/commits contains the two following commits which are both identical
- https://github.com/olblak/kubernetes-marketplace/pull/118/commits/5378da081cc57adbdea744670563184032d93dc2
- https://github.com/olblak/kubernetes-marketplace/pull/118/commits/32cabe6345b02db2118db35ca2830d8c8cdbe57a
Expected Behavior
I expect to only see four commit
Steps To Reproduce
No response
Environment
- OS:linux
- updatecli: 0.76.0
Anything else?
No response
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 15 (8 by maintainers)
Thanks for highlighting this issue. This feature was introduced as experimental in https://github.com/updatecli/updatecli/pull/2070 The tricky part is commits are pushed to GitHub via the api and the local directory get out of sync
@argoyle I finally had the time to look into this, and I think I found the solution. Could you have another look? Thanks @MattiasAng for the useful hints