ungoogled-chromium: [macOS] waitable_event_posix.o fails to compile

Since 5e9a70ec9da7084d3485fe44df4344eb8cea13c1, develop branch has been failing to build on base/synchronisation/waitable_event_posix.o:

[214/374] c++ -MMD -MF base/synchronization/waitable_event_posix.o.d  -I/var/folders/sl/ygqg15cj1tx6qnxhyvs40rrh0000gn/T/tmpfSjQ4H/gen -I/Users/Artur/ungoogled-chromium/build/sandbox -DNO_TCMALLOC -D__STDC_FORMAT_MACROS -O2 -g0 -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -pthread -pipe -fno-exceptions -std=c++14 -c /Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc -o base/synchronization/waitable_event_posix.o
FAILED: base/synchronization/waitable_event_posix.o 
c++ -MMD -MF base/synchronization/waitable_event_posix.o.d  -I/var/folders/sl/ygqg15cj1tx6qnxhyvs40rrh0000gn/T/tmpfSjQ4H/gen -I/Users/Artur/ungoogled-chromium/build/sandbox -DNO_TCMALLOC -D__STDC_FORMAT_MACROS -O2 -g0 -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -pthread -pipe -fno-exceptions -std=c++14 -c /Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc -o base/synchronization/waitable_event_posix.o
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:46:19: error: unknown type name 'WaitableEventKernel'; did you mean 'WaitableEvent'?
    : kernel_(new WaitableEventKernel(reset_policy, initial_state)) {}
                  ^~~~~~~~~~~~~~~~~~~
                  WaitableEvent
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event.h:54:19: note: 'WaitableEvent' declared here
class BASE_EXPORT WaitableEvent {
                  ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:46:7: error: member initializer 'kernel_' does not name a non-static data member or base class
    : kernel_(new WaitableEventKernel(reset_policy, initial_state)) {}
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:51:25: error: use of undeclared identifier 'kernel_'
  base::AutoLock locked(kernel_->lock_);
                        ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:52:3: error: use of undeclared identifier 'kernel_'
  kernel_->signaled_ = false;
  ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:56:25: error: use of undeclared identifier 'kernel_'
  base::AutoLock locked(kernel_->lock_);
                        ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:58:7: error: use of undeclared identifier 'kernel_'
  if (kernel_->signaled_)
      ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:61:7: error: use of undeclared identifier 'kernel_'
  if (kernel_->manual_reset_) {
      ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:62:5: error: use of undeclared identifier 'SignalAll'; did you mean 'Signal'?
    SignalAll();
    ^~~~~~~~~
    Signal
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:55:21: note: 'Signal' declared here
void WaitableEvent::Signal() {
                    ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:63:5: error: use of undeclared identifier 'kernel_'
    kernel_->signaled_ = true;
    ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:67:10: error: use of undeclared identifier 'SignalOne'; did you mean 'Signal'?
    if (!SignalOne())
         ^~~~~~~~~
         Signal
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:55:21: note: 'Signal' declared here
void WaitableEvent::Signal() {
                    ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:67:9: error: invalid argument type 'void' to unary expression
    if (!SignalOne())
        ^~~~~~~~~~~~
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:68:7: error: use of undeclared identifier 'kernel_'
      kernel_->signaled_ = true;
      ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:73:25: error: use of undeclared identifier 'kernel_'
  base::AutoLock locked(kernel_->lock_);
                        ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:75:23: error: use of undeclared identifier 'kernel_'
  const bool result = kernel_->signaled_;
                      ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:76:18: error: use of undeclared identifier 'kernel_'
  if (result && !kernel_->manual_reset_)
                 ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:77:5: error: use of undeclared identifier 'kernel_'
    kernel_->signaled_ = false;
    ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:174:3: error: use of undeclared identifier 'kernel_'
  kernel_->lock_.Acquire();
  ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:175:7: error: use of undeclared identifier 'kernel_'
  if (kernel_->signaled_) {
      ^
/Users/Artur/ungoogled-chromium/build/sandbox/base/synchronization/waitable_event_posix.cc:176:10: error: use of undeclared identifier 'kernel_'
    if (!kernel_->manual_reset_) {
         ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 17 (17 by maintainers)

Most upvoted comments

@Eloston It does break indeed, but a bit further 😉

[365/365] c++  -o gn tools/gn/gn_main.o -framework AppKit -framework CoreFoundation -framework Foundation -framework Security libevent.a base.a gn_lib.a dynamic_annotations.a
FAILED: gn 
c++  -o gn tools/gn/gn_main.o -framework AppKit -framework CoreFoundation -framework Foundation -framework Security libevent.a base.a gn_lib.a dynamic_annotations.a
Undefined symbols for architecture x86_64:
  "tracked_objects::ThreadData::InitializeThreadContext(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)", referenced from:
      base::PlatformThread::SetName(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in base.a(platform_thread_mac.o)
  "tracked_objects::ThreadData::TallyRunOnNamedThreadIfTracking(base::TrackingInfo const&, tracked_objects::TaskStopwatch const&)", referenced from:
      base::SequencedWorkerPool::Inner::ThreadLoop(base::SequencedWorkerPool::Worker*) in base.a(sequenced_worker_pool.o)
      base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) in base.a(task_annotator.o)
  "tracked_objects::TaskStopwatch::Stop()", referenced from:
      base::SequencedWorkerPool::Inner::ThreadLoop(base::SequencedWorkerPool::Worker*) in base.a(sequenced_worker_pool.o)
      base::RunLoop::Run() in base.a(run_loop.o)
      base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) in base.a(task_annotator.o)
  "tracked_objects::TaskStopwatch::Start()", referenced from:
      base::SequencedWorkerPool::Inner::ThreadLoop(base::SequencedWorkerPool::Worker*) in base.a(sequenced_worker_pool.o)
      base::RunLoop::Run() in base.a(run_loop.o)
      base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) in base.a(task_annotator.o)
  "tracked_objects::TaskStopwatch::TaskStopwatch()", referenced from:
      base::SequencedWorkerPool::Inner::ThreadLoop(base::SequencedWorkerPool::Worker*) in base.a(sequenced_worker_pool.o)
      base::RunLoop::Run() in base.a(run_loop.o)
      base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) in base.a(task_annotator.o)
  "tracked_objects::TaskStopwatch::~TaskStopwatch()", referenced from:
      base::SequencedWorkerPool::Inner::ThreadLoop(base::SequencedWorkerPool::Worker*) in base.a(sequenced_worker_pool.o)
      base::RunLoop::Run() in base.a(run_loop.o)
      base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) in base.a(task_annotator.o)
  "base::TrackingInfo::TrackingInfo(tracked_objects::Location const&, base::TimeTicks)", referenced from:
      base::SequencedWorkerPool::Inner::PostTask(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const*, base::SequencedWorkerPool::SequenceToken, base::SequencedWorkerPool::WorkerShutdown, tracked_objects::Location const&, base::OnceCallback<void ()>, base::TimeDelta) in base.a(sequenced_worker_pool.o)
      base::PendingTask::PendingTask(tracked_objects::Location const&, base::OnceCallback<void ()>) in base.a(pending_task.o)
      base::PendingTask::PendingTask(tracked_objects::Location const&, base::OnceCallback<void ()>, base::TimeTicks, bool) in base.a(pending_task.o)
      base::PendingTask::PendingTask(tracked_objects::Location const&, base::OnceCallback<void ()>) in base.a(pending_task.o)
  "base::TrackingInfo::TrackingInfo()", referenced from:
      base::SequencedWorkerPool::Inner::ThreadLoop(base::SequencedWorkerPool::Worker*) in base.a(sequenced_worker_pool.o)
  "base::TrackingInfo::~TrackingInfo()", referenced from:
      base::SequencedWorkerPool::Inner::ThreadLoop(base::SequencedWorkerPool::Worker*) in base.a(sequenced_worker_pool.o)
      base::SequencedWorkerPool::Inner::PostTask(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const*, base::SequencedWorkerPool::SequenceToken, base::SequencedWorkerPool::WorkerShutdown, tracked_objects::Location const&, base::OnceCallback<void ()>, base::TimeDelta) in base.a(sequenced_worker_pool.o)
      std::__1::__tree<base::(anonymous namespace)::SequencedTask, base::(anonymous namespace)::SequencedTaskLessThan, std::__1::allocator<base::(anonymous namespace)::SequencedTask> >::destroy(std::__1::__tree_node<base::(anonymous namespace)::SequencedTask, void*>*) in base.a(sequenced_worker_pool.o)
      base::PendingTask::~PendingTask() in base.a(pending_task.o)
      base::PendingTask::~PendingTask() in base.a(pending_task.o)
  "base::subtle::ReadWriteLock::ReadAcquire()", referenced from:
      base::internal::IncomingTaskQueue::PostPendingTask(base::PendingTask*) in base.a(incoming_task_queue.o)
  "base::subtle::ReadWriteLock::ReadRelease()", referenced from:
      base::internal::IncomingTaskQueue::PostPendingTask(base::PendingTask*) in base.a(incoming_task_queue.o)
  "base::subtle::ReadWriteLock::WriteAcquire()", referenced from:
      base::internal::IncomingTaskQueue::WillDestroyCurrentMessageLoop() in base.a(incoming_task_queue.o)
  "base::subtle::ReadWriteLock::WriteRelease()", referenced from:
      base::internal::IncomingTaskQueue::WillDestroyCurrentMessageLoop() in base.a(incoming_task_queue.o)
  "base::subtle::ReadWriteLock::ReadWriteLock()", referenced from:
      base::internal::IncomingTaskQueue::IncomingTaskQueue(base::MessageLoop*) in base.a(incoming_task_queue.o)
      base::internal::IncomingTaskQueue::IncomingTaskQueue(base::MessageLoop*) in base.a(incoming_task_queue.o)
  "base::subtle::ReadWriteLock::~ReadWriteLock()", referenced from:
      base::internal::IncomingTaskQueue::~IncomingTaskQueue() in base.a(incoming_task_queue.o)
  "tracked_objects::TaskStopwatch::StartTime() const", referenced from:
      base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) in base.a(task_annotator.o)

arutr on Nov 30, 2017