uncss: Root-relative URLs do not work for JS files

Root-relative URLs for JS files cause errors like this: Error: Could not load script: "file:///test.js"/

Originally posted in https://github.com/giakki/uncss/pull/280#issuecomment-281437450, because I thought the issue was specific to the JSDom implementation. @RyanZim informed me, though, that the same error occurs with PhantomJS, it is just quietly ignored.

@vseventer suggested:

uncss allows /css/main.css, so there is no reason why /js/main.js shouldn’t be supported also. This could be fixed by having htmlroot (or, more precise, utility.parsePath) apply to stylesheets and scripts (currently, it only applies to stylesheets).

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 21 (16 by maintainers)

Most upvoted comments

Ok, I found it! Stupid mistake…

.pipe(postcss([uncss(config.uncss)]))

It needs to be an array.

XhmikosR on Aug 7, 2017

I think this issue is no longer valid, yeah. Root-relative files work fine with htmlroot.

XhmikosR on Aug 7, 2017

Ok thanks. Can you provide a self-contained repro case? Or can you log and share the values I requested above? Namely, what is the css object being passed into getUsedSelectors ?

mikelambert on Aug 7, 2017

uncss allows /css/main.css, so there is no reason why /js/main.js shouldn’t be supported also.

I agree with @vseventer.

I don’t know if/how this is possible via PhantomJS, however, in jsdom, this could be done via

config.resourceLoader: a function that intercepts subresource requests and allows you to re-route them, modify, or outright replace them with your own content.

I will submit a patch to the jsdom branch when I get a chance (unless someone gets there before me). When it is merged to the jsdom branch, I will publish a new version of uncss-jsdom.

RyanZim on Feb 22, 2017