AutoDispose: Lint error with lenient mode activated

Hi, I wanted to handle myself the lifecycle of this request, so I removed my Autodispose call but the lenient error appeared. I do have activated lenient mode in my gradle.properties, cleaned and rebuild, still the error remains.

Library version: 1.1.0

Repro steps or stacktrace: In this case, disposables is a CompositeDisposable which I’m disposing in the onDetach function

About this issue

Original URL
State: closed
Created 5 years ago
Comments: 17

Commits related to this issue

Bump lint minApi to 3.3.0 (#334) From discussion in #333 — committed to uber/AutoDispose by ShaishavGandhi 5 years ago

Most upvoted comments

Alright so I’m able to reproduce this. It’s actually looking for the module’s gradle.properties file instead of the root project’s gradle.properties file. For now, you can either @SuppressWarning it or you can add a module level gradle.properties file (not ideal I know)

I’m working on a fix. Thanks for reporting!

ShaishavGandhi on Feb 28, 2019

Odd. In any case, I’d be fine with raising the requirement to 3.3.x since that’s stable now

On Tue, Feb 26, 2019 at 3:41 PM Shaishav Gandhi notifications@github.com wrote:

Hmm technically we our minApi is set to 3.2.0 so it should’ve worked. But it’s possible that the Android Studio version is the culprit. i.e AS 3.4 requires 3.3 or a variation of that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/uber/AutoDispose/issues/333#issuecomment-467605122, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTEvrnO-4kgNqjbrczyfCY6RdnL6__Aks5vRZwKgaJpZM4bPoeQ .

ZacSweers on Feb 26, 2019

Great to hear, thanks! We can look to codify the minimum supported version as a followup

On Tue, Feb 26, 2019 at 11:36 AM Florentin notifications@github.com wrote:

Indeed the version of AGP was the culprit, some legacy code I never thought to upgrade Upgrade to 3.3.1 fixed the issue Thanks a lot ! 👍

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/uber/AutoDispose/issues/333#issuecomment-467512734, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTEvmkjGxMRrycic0eNOqE_f2MOagPjks5vRWKYgaJpZM4bPoeQ .

ZacSweers on Feb 26, 2019