husky: git commit hooks never get created when husky v5 is installed

Hi @DouglasDev,

It’s normal behaviour with v5. You need to run npx husky install and create hooks with npx husky add .husky/pre-commit ....

You can check that it’s working by creating a new folder and running the following commands:

$ cd /tmp
$ mkdir test && cd test
$ git init && npm init -y && npm install husky -D

$ npx husky install
$ npx husky add .husky/pre-commit "echo hello"
$ git add package.json
$ git commit -m "test: hello should be printed"

@typicode Thanks for your reply. I will take your word for it that it works, but that seems like this change in the installation process will confuse many developers since none the dozens of tutorials on the internet on how to add husky to a project (for example the create react app docs and the prettier docs) mention this. I guess this change is necessary for the improved performance/memory usage? Perhaps it would be helpful to show these instructions in the terminal after you install husky?

I added backslash as a workaround. npx husky add .husky/pre-commit \“npm run test\”

but it doesn’t work if it is put in package.json

In windows environments the same problem exists (see #871). In that case it can be solved by calling the locally installed version of husky (.\node_modules\.bin\husky add .husky/pre-commit "echo hello"). Seems to me like calling husky with npx has a path problem.

Same issue here, we’re still using npm@6 on Windows 10 and the command npx --no is not yet available. On my side, I added 2 scripts in my “package.json” file :

"scripts": {
  "commitlint": "commitlint",
  "lint-staged": "lint-staged",
}

And thanks to that, my 2 files (with shebang as proposed here: https://github.com/typicode/husky/issues/864#issuecomment-778857821) are now triggered when I do git commit -m "my commit message"

“.husky/commit-msg”:

#!/usr/bin/env bash

npm run commitlint -- --edit $1

“.husky/pre-commit”:

#!/usr/bin/env bash

npm run lint-staged

If it can help someone 😊

Thanks for this upgrade @typicode !

I have the same issue! I upgraded to husky@5.0.9 and just noticed my pre-commit and pre-push hooks are not being triggered.

They worked well with husky@4.3.8.

my husky.config.js

module.exports = {
  hooks: {
    'pre-commit': lint-staged && npm run test:changed'])
  }
};