bootstrap: Bootstrap v4.4.1 collapse doesn't work with jQuery v3.5.0

Hello together,

after upgrade to jQuery 3.5.0 I’m getting an exception TypeError: Cannot convert object to primitive value while clicking to navbar-toggler button

It leads to the line https://github.com/twbs/bootstrap/blob/dca1ab7d877bc4b664b43604657a2b5fbe2b4ecb/js/src/collapse.js#L346

Works fine with jQuery 3.4.1.

Any system and browser.

About this issue

Original URL
State: closed
Created 4 years ago
Reactions: 25
Comments: 29 (12 by maintainers)

Commits related to this issue

Pin jquery to 3.4.1 until twbs/bootstrap#30553 is fixed — committed to compiler-explorer/compiler-explorer by mattgodbolt 4 years ago
Revert "Update JS dependencies" - see https://github.com/twbs/bootstrap/issues/30553 This reverts commit 5d48fc546aba9a47db0a1d264e47c15f22f43767. — committed to fisharebest/webtrees by fisharebest 4 years ago
Open all collapses until jQuery or Bootstrap are fixed https://github.com/twbs/bootstrap/issues/30553 — committed to annict/annict by shimbaco 4 years ago
Update jQuery to 3.5.0 — committed to CTFd/CTFd by ColdHeat 4 years ago

Most upvoted comments

True I had trouble when I tried that but tests were broken due to other jQuery changes.

I’ll try again later in my branch.

On Sun, Apr 12, 2020, 16:50 Alazar Kassahun notifications@github.com wrote:

if (!data && _config.toggle && /show|hide/.test(config))

should be

if (!data && _config.toggle && /show|hide/.test(_config))

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/twbs/bootstrap/issues/30553#issuecomment-612617589, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVLNM64H276MOT7E33PCLRMHBJVANCNFSM4MF4XAFA .

XhmikosR on Apr 12, 2020

@alazark94 thanks bruh!, work as fine

ghost on Apr 14, 2020

Change it to “jquery”: “3.4.1”

Just remove the ‘^’ character

alazark94 on Apr 14, 2020

in node_modules/bootsrap/dist/js/bootstrap.js line 1509 change

if (!data && _config.toggle && /show|hide/.test(config))

if (!data && _config.toggle && /show|hide/.test(_config))

or use jquery 3.4.1 until twbs/bootstrap#30553 is fixed

alazark94 on Apr 12, 2020