ngx-admin-lte: Explicit dependency on jquery is not necessary, should be removed IMHO

In 2.0.0-beta.9 jquery was removed as a direct dependency, it is an indirect dependency.

In 2.0.0-beta.10 jquery was re-introduced.

Fact is, you don’t need to specify this dependency.

Because if you leave it out, admin-lte has a dependency on jqeury and will pick it up. You end up having node_modules/jquery anyway.

For the same reason, we should NOT explicitly include bootstrap.

Why not ?

Because jquery and bootstrap are transitive dependencies of our dependencies, most likely admin-lte.

admin-lte@2.3.11 depends on a specific bootstrap and jquery version. admin-lte@2.4.x depends on slightly different bootstrap and jquery version.

All I am saying is, let admin-lte@x.y figure out which sub-dependencies it has. If we specify a certain version, we are only asking for more maintenance on OUR side.

Where is the benefit of that ?

My web app has never specified jquery EXPLICITLY, because admin-lte and/or bootstrap has always had that responsibility.

Guess what, bootstrap 4 apparently has no more direct dependency on jquery.

It has a peerDependency relationship though, see: bootstrap dependency on jquery