Proxmox: changedetection.io install script missing playwright pip
Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
Greetings from changedetection.io!
I’m referring to this issue https://github.com/dgtlmoon/changedetection.io/issues/2132
basically the user ran some install script, but that script is missing the pip3 install playwright part
https://github.com/tteck/Proxmox/blob/main/ct/changedetection.sh
However it is present here
https://github.com/tteck/Proxmox/blob/main/install/changedetection-install.sh
I have to admit that I know little about proxmox, but this seems to be an inconsistancy.
Which Linux distribution are you employing?
Ubuntu 23.04
If relevant, including screenshots or a code block can be helpful in clarifying the issue.
No response
Please provide detailed steps to reproduce the issue.
Note: I cannot confirm if this the RIGHT way to install it, the other script https://github.com/tteck/Proxmox/blob/main/install/changedetection-install.sh has it correct, I do not know why this user chose this “.../ct/changedetection.sh” script over the other one.
execute 'bash -c "$(wget -qLO - https://github.com/tteck/Proxmox/raw/main/ct/changedetection.sh)"' on the changedetection LXC
rebooting the LXC
triggering a recheck of a playwright request
Another thing is that the application should be run with the env var PLAYWRIGHT_DRIVER_URL=ws://localhost:3000/?stealth=1&--disable-web-security=true so that it knows where to connect/find playwright, can this also be added to https://github.com/tteck/Proxmox/blob/main/install/changedetection-install.sh ?
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 18 (8 by maintainers)
@tteck thanks to you 😃 have a coffee on us today 😃
https://github.com/tteck/Proxmox/commit/1597f560c7138397235dac6ca5dc54d19d96444d
https://github.com/dgtlmoon/changedetection.io/commit/d8ee5472f18c930b4e504fd4c0a9bca3caba9f1e#diff-1a79d924d1840c485238e66772391268a89c95b781d69091384cf1ea1ac146c9L155
yes that is correct
It’s already incorporated https://github.com/tteck/Proxmox/blob/702dbc7bbaded6d4a00e60dea5ecbad33f61a05c/install/changedetection-install.sh#L125