torbrowser-launcher: torbrowser-launcher does not run ubuntu 22.04

Hi. I know I am using a daily build of ubuntu 22.04, but is there any way to solve the issue? The code:

torbrowser-launcher 
Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.3.3
https://github.com/micahflee/torbrowser-launcher
Downloading Tor Browser for the first time.
Downloading https://aus1.torproject.org/torbrowser/update_3/release/Linux_x86_64-gcc3/x/en-US

Traceback (most recent call last):
  File "/usr/bin/torbrowser-launcher", line 30, in <module>
    torbrowser_launcher.main()
  File "/usr/lib/python3/dist-packages/torbrowser_launcher/__init__.py", line 98, in main
    gui.move(
TypeError: arguments did not match any overloaded call:
  move(self, QPoint): argument 1 has unexpected type 'float'
  move(self, int, int): argument 1 has unexpected type 'float'

About this issue

Original URL
State: closed
Created 2 years ago
Reactions: 12
Comments: 18 (4 by maintainers)

Commits related to this issue

obey int at argument when launching GUI see https://github.com/micahflee/torbrowser-launcher/issues/628 — committed to niccokunzmann/torbrowser-launcher by niccokunzmann 2 years ago
Fix python strict type checking in Python 3.9+ Python 3.9+ started doing strict enforcement of types. This results in the GUI function methods not functioning properly in modern Python environments.... — committed to teward/torbrowser-launcher by teward 2 years ago

Most upvoted comments

Open as root file /usr/lib/python3/dist-packages/torbrowser_launcher/init.py

At the end of the file (lines 98 - 101) locate:

            gui.move(
                (desktop.width() - window_size.width()) / 2,
                (desktop.height() - window_size.height()) / 2
            )

Edit it to:

            gui.move(
                (desktop.width() - window_size.width()) // 2,
                (desktop.height() - window_size.height()) // 2
            )

As you see, the difference is replacing / with //.

Done.

icceland on Aug 6, 2022

All: This is a Python 3.10 issue introduced by heavier strictness - see #599 - it’s the same issue regardless of the distro in use

teward on Jun 22, 2022

@icceland and others: Pull request made (see #646) using the code as stated here by icceland modified into the init file as based here in the code (which is ${GIT_ROOT}/torbrowser_launcher/__init__.py)

teward on Aug 7, 2022

Thanks for your kind answer @Am0rphous . I’m honestly glad to be somehow helpful. I’m barely familiar with github structure and out of time to learn it at the moment. It would be generous if you could do this for me and all thees other users out there. Feel free to do it for me. Can we count with you? Kind regards!

Awesome, thanks @icceland ! I can confirm that this made it work on 22.04. Did you make a pull request?

I was already prepping a patch that I can SRU into Ubuntu’s packaging. I can adapt it to a PR and give you credit in the commit message @icceland.

teward on Aug 7, 2022

Thanks for your kind answer @Am0rphous . I’m honestly glad to be somehow helpful. I’m barely familiar with github structure and out of time to learn it at the moment. It would be generous if you could do this for me and all thees other users out there. Feel free to do it for me. Can we count with you? Kind regards!

Awesome, thanks @icceland ! I can confirm that this made it work on 22.04.

Did you make a pull request?

icceland on Aug 7, 2022

Awesome, thanks @icceland ! I can confirm that this made it work on 22.04.

Did you make a pull request?

Am0rphous on Aug 7, 2022