RazorLight: Child template just does not render in a couple of scenarios after .NET 2.0 upgrade

Just upgraded to .NET 2.0 beta 1. It is working, compiling, etc. But in a couple of scenarios, my child HTML template just does not render. In the generated HTML there’s just nothing there, also no errors.

E.g. this used to work in 1.1, not anymore in 2.0:

<tr style="@(rs.ActivityBookings == null || rs.ActivityBookings.Count == 0 ? "display:inherit" : "display:none")">

And when using a foreach, I now have to check if there are more than zero items. Without that check, again nothing rendered.

This is quite frustrating as this is trial and error, with no clue why this is not working. Am I doing something wrong?

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 35 (3 by maintainers)

Commits related to this issue

#134 - Fix IncludeAsync rendering issues — committed to toddams/RazorLight by toddams 6 years ago

Most upvoted comments

@toddams When do you guess the nuget package will be released for this fix?

sbinkert on Jan 15, 2018

@wik8wz , is your NoPoolingViewBufferScope work fine in production? Have you noticed any issues like high memory consumption or memory leak?

Nothing was reported until now. We do recycle our app pool everyday anyway. Our service is not very loaded at the moment. We are sending ~250 rendered email per month right now

wik8wz on Jun 5, 2019

@toddams , are you ok with https://github.com/wik8wz/RazorLight/commit/35f06da97ec7da7677379932397560410a44d04b implementation? Will you accept PR with it? We are also using his branch in a couple of projects without any issues.

MNF on Sep 11, 2019

Commit 0dbc5e1d174411530c3ab81db94dfc3444dd4a4d does not fix rendering issue. It is still occurring for large templates. The problem is caused by MemoryPoolViewBufferScope implementation (clearing/passing/returning the buffer). I implemented workaround here https://github.com/wik8wz/RazorLight/commit/35f06da97ec7da7677379932397560410a44d04b

wik8wz on Jan 15, 2019

I found the bug, and that is a total disaster!) Can’t imagine how we’ve been using this for such a long time without facing this bug. It happens with big templates

Will prepare the next release, thank you for the very detailed description

toddams on Jan 11, 2018

@jzabroski we are not having any issues with the partial views with big templates ever since we switched to using the branch that @wik8wz created a long time ago. We have just been using his source code in our solution we have it as a project and we can debug as needed. We did have an issue with the cache yesterday, but so far after a rebuild and re-deploy it appears to be working fine. We are scheduled to go into Production this weekend.

markleacompassphs on Dec 12, 2019

I’m waiting on @toddams to give me access to update the Nuget package, then within a few days I should be able to fix all these problems. He gave me write access to the repo, but not the nuget feed.

jzabroski on Nov 11, 2019

@wik8wz Why sadly? Friend request me on LinkedIn, who knows, maybe if you love C# I would love to work with you.

Thanks for your help!

jzabroski on Oct 25, 2019

@jzabroski I created one here: https://github.com/toddams/RazorLight/pull/275 Sadly I’m no longer working with C# and therefore will no longer support development here. I hope this works for you (I saw there are no merge conflicts)

wik8wz on Oct 25, 2019

I recently requested write access to this repo form @toddams in order to help out with the project and get a few key bugs fixed.

@wik8wz Do you have any interest in a pull request for your fix? I’d rather you formally submit one than me copy-paste your contribution, on legal grounds.

jzabroski on Oct 25, 2019

@markleacompassphs in meantime we usage of service in production increased significantly to 1000s emails per month. Did not face rendering issue again since fix was implemented (over 8 months now). Quite happy how it is working to be honest.

wik8wz on Sep 16, 2019

Big thanks to wik8wz for fixing this issue. We are using your branch and no longer have the partial view issues that we were facing. Another interesting thing we found was that you need to be careful about making var assignments inside of the partial views, you are better served to just directly looking into your model for all of your data.

markleacompassphs on Sep 11, 2019

I hit what sounds like this bug today… sorry for the formatting… could not quite get i right… so the point in the bottom HTML is missing as the error is not visible…

Fairly simple main view:

@using Microsoft.EntityFrameworkCore.Internal @using RazorLight @using TMServerDb.Models.Core @inherits RazorLight.TemplatePage<TMServerAPI.Models.Reporting.ReportViewModel> @{ DisableEncoding = true; } <!doctype html>


<html lang="en">
<head>
    <link rel="stylesheet" href="~/Bootstrap/css/bootstrap.css" />
    <title>@Model.Definition.Name</title>
</head>
<body>
    @{
        await IncludeAsync("..\\StandardItems\\TournamentHeader.cshtml", (Model.Data as TMServerDb.Models.Core.MatchSet).Tournament);
    }
    

    @{
        var ms = Model.Data as TMServerDb.Models.Core.MatchSet;
        var grouped = ms.Matches.OrderBy(n => n.Number).ThenBy(p => p.Pitch.Name).GroupBy(s => s.PlannedStart);
    foreach (IGrouping<DateTime, Match> grouping in grouped)
    {
        await IncludeAsync("..\\StandardItems\\MatchGrouping.cshtml", grouping);

        <br/>
    }
}

</body>
</html>

The nested view:

@using RazorLight @using TMServerDb.Models.Core @inherits RazorLight.TemplatePage<IGrouping<DateTime, TMServerDb.Models.Core.Match>>



    @{
        foreach (Match match in Model.OrderBy(x => x.Pitch.Name))
        {
            
        }
    }
    
    
    
        @Model.Key.Date.ToShortDateString()
        @Model.Key.ToShortTimeString()
        
    
    
        #
        Pitch
        Class
    
    
    
                @match.Number
                @match.Pitch.Name
                @match.Class.Name

@Model.Key.Date.ToShortDateString()	@Model.Key.ToShortTimeString()
@match.Number	@match.Pitch.Name	@match.Class.Name

When rendering, in my test, I have 30 odd groupings… but only a few make it to the pdf… intercepting the result from the rendering, explains why… notice the numerous ending of html and body tags…

<!doctype html>


<html lang="en">
<head>
    <link rel="stylesheet" href="~/Bootstrap/css/bootstrap.css" />
    <title>Tournament Schedule</title>
</head>
<body>
<div>
    Amsterdam Open 2019
    Uithoorn
    01-06-2019 - 02-06-2019
</div>
    


    
    
        01-06-2019
        09:00
        
    
    
        #
        Pitch
        Class
    
    
    
            
                1
                Pitch 1
                4th Division
            
            
                2
                Pitch 2
                1st Division
            
            
                3
                Pitch 3
                Women Division
            
            
                4
                Pitch 4
                Women Division
            
            
                5
                Pitch 5
                2nd Division
            
            
                6
                Pitch 6
                3th Division
            
    
            


    
    
        01-06-2019
        09:30
        
    
    
        #
        Pitch
        Class
    
    
    
            
                7
                Pitch 1
                4th Division
            
            
                8
                Pitch 2
                2nd Division
            
            
                9
                Pitch 3
                1st Division
            
            
                10
                Pitch 4
                2nd Division
            
            
                11
                Pitch 5
                1st Division
            
            
                12
                Pitch 6
                3th Division
            
    
            


    
    
        01-06-2019
        10:00
        
    
    
        #
        Pitch
        Class
    
    
    
            
                13
                Pitch 1
                4th Division
            
            
                14
                Pitch 2
                Women Division
            
            
                15
                Pitch 3
                2nd Division
            
            
                16
                Pitch 4
                2nd Division
            
            
                17
                Pitch 5
                1st Division
            
            
                18
                Pitch 6
                3th Division
            
    
            


    
    
        01-06-2019
        10:30
        
    
    
        #
        Pitch
        Class
    
    
    
            
                19
                Pitch 1
                4th Division
            
            
                20
                Pitch 2
                1st Division
            
            
                21
                Pitch 3
                Women Division
            
            
                22
                Pitch 4
                1st Division
            
            
                23
                Pitch 5
                2nd Division
            
            
                24
                Pitch 6
                3th Division
            
    
            

            

</body>
</html>            

</body>
</html>            

</body>
</html>            

</body>
</html>            

</body>
</html>            

</body>
</html>            

</body>
</html>

01-06-2019	09:00
1	Pitch 1	4th Division
2	Pitch 2	1st Division
3	Pitch 3	Women Division
4	Pitch 4	Women Division
5	Pitch 5	2nd Division
6	Pitch 6	3th Division

01-06-2019	09:30
7	Pitch 1	4th Division
8	Pitch 2	2nd Division
9	Pitch 3	1st Division
10	Pitch 4	2nd Division
11	Pitch 5	1st Division
12	Pitch 6	3th Division

01-06-2019	10:00
13	Pitch 1	4th Division
14	Pitch 2	Women Division
15	Pitch 3	2nd Division
16	Pitch 4	2nd Division
17	Pitch 5	1st Division
18	Pitch 6	3th Division

01-06-2019	10:30
19	Pitch 1	4th Division
20	Pitch 2	1st Division
21	Pitch 3	Women Division
22	Pitch 4	1st Division
23	Pitch 5	2nd Division
24	Pitch 6	3th Division

hhgm on May 13, 2019

We went live with the fork which I created. Might switch back to original one when fixed.

@wik8wz Can you open a PR from your fork with the fix?

ADNewsom09 on Mar 27, 2019

01-06-2019	09:00
#	Pitch	Class
1	Pitch 1	4th Division
2	Pitch 2	1st Division
3	Pitch 3	Women Division
4	Pitch 4	Women Division
5	Pitch 5	2nd Division
6	Pitch 6	3th Division