factory_bot_rails: factory_girl_rails/factory_bot_rails RuntimeError: can't modify frozen Array

Great tip @composerinteralia.

basically to solve this issue:

rubocop \
  --require rubocop-rspec \
  --only FactoryBot/AttributeDefinedStatically \
  --auto-correct

The errors with 5.0 occur because of the deprecation of static var in factories. Gl all.

Having the same problem after changing to FactoryBot from FactoryGirl and factory_girl_rails to factory_bot_rails

NOTE: if you get this test error, the very first test error will give you more details on what’s breaking.

In my case, just changed my factory field from password 123456 to password { 123456 } solved.

@nezirz there were some deprecations in factory_bot 4.11, so you will want to upgrade to that version and deal with the warnings before upgrading to factory_bot 5.0.

gem install rubocop-rspec and then rubocop --require rubocop-rspec --only FactoryBot/AttributeDefinedStatically --auto-correct

worked for me

@joshuaclayton nothing too useful, I’m afraid.

Here it is, in case it helps:

An error occurred while loading .<spec_path>_spec.rb.
Failure/Error: require File.expand_path("../../config/environment", __FILE__)

FrozenError:
  can't modify frozen Array
# [gem path]/actionpack-5.2.1/lib/action_dispatch/middleware/stack.rb:76:in `insert'
# [gem path]/actionpack-5.2.1/lib/action_dispatch/middleware/stack.rb:76:in `insert'
# [gem path]/sentry-raven-2.7.4/lib/raven/integrations/rails.rb:10:in `block in <class:Rails>'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:32:in `instance_exec'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:32:in `run'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:61:in `block in run_initializers'
# [gem path]/railties-5.2.1/lib/rails/initializable.rb:60:in `run_initializers'
# [gem path]/railties-5.2.1/lib/rails/application.rb:361:in `initialize!'
# ./config/environment.rb:17:in `<top (required)>'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `block in require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:253:in `load_dependency'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# ./spec/spec_helper.rb:14:in `<top (required)>'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `block in require'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:253:in `load_dependency'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:287:in `require'
# .<spec_path>_spec.rb:1:in `<top (required)>'
# [gem path]/zeus-0.15.14/lib/zeus/load_tracking.rb:82:in `load'
# [gem path]/zeus-0.15.14/lib/zeus/load_tracking.rb:82:in `load'
# [gem path]/zeus-0.15.14/lib/zeus/load_tracking.rb:74:in `load'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:281:in `block in load'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:253:in `load_dependency'
# [gem path]/activesupport-5.2.1/lib/active_support/dependencies.rb:281:in `load'

This is on Rails 5.2.1 and Ruby 2.5.1

(Edits: Bad copy and paste when removing long [gem path] 👍)

I had the same problem when tried to upgrade fromrails 5.2.0 to 5.2.2.1using bundle update rails command, its also updated many other gems one of them was factory_bot from 4.10.0 to 5.0.2 so solution was to downgrade to 4.10.0 by specifying the version number for factory_bot to gem "factory_bot_rails", "~> 4.10.0"

This happened to me when I declared two factories w/ the same name.

@joshuaclayton - Fast response! There was a few, but we’ve since narrowed it down to this gem being bumped - eg; we took this upgrade out and everything was fine.

Failure/Error: require File.expand_path("../../config/environment", __FILE__)

FrozenError:
  can't modify frozen Array

# ./config/environment.rb:17:in `<top (required)>'
# ./spec/spec_helper.rb:14:in `<top (required)>'
# ./spec/<our_spec_file>_spec.rb:1:in `<top (required)>'

respectively:
-> Rails.application.initialize!
-> require File.expand_path("../../config/environment", __FILE__)
-> require 'spec_helper'

(Edit: tag)

This same issue seems to have happened to us on the update from 4.10.0 to 4.11.0, although the releases show “No notable changes”

We literally changed the version number and bundled.

@schmijos there are no intentional breaking changes from factory_bot_rails 5.0.1 to 5.0.2. The FrozenError is not coming from factory_bot (see https://github.com/thoughtbot/factory_bot_rails/issues/303 for details). If you want to see the underlying factory_bot error try running just one of the failing specs at a time.

Sorted! The problem was that the grep command given in the blog post to Replace All Constant References didn’t actually change all the instances of FactoryGirl in the code base. After we found that and did a global change with Atom it all works fine. This is an example diff of one of the files missed by the grep that I had to manually change:

git diff spec/factories/activation_code.rb
diff --git a/spec/factories/activation_code.rb b/spec/factories/activation_code.rb
index 493f7942..8c727cb5 100644
--- a/spec/factories/activation_code.rb
+++ b/spec/factories/activation_code.rb
@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :activation_code do
     code { Faker::Lorem.characters(6) }
     code_valid { true }

Something like this grep looks like it fixes it: grep -rl 'FactoryGirl' ./ | xargs sed -i '' 's/FactoryGirl/FactoryBot/g'

I was getting the same error. I fixed by removing require ‘rails_helper’ from spec files. It was causing the issue for me. I am not sure but it seems somewhere it was trying to load these helpers multiple time and it was causing can’t modify frozen Array.

The stack trace given on rails/rails#33745 looks fairly similar to this, and it seems to have been related to a rails_admin initializer running after the build_middleware_stack initializer.

The build_middleware_stack initializer freezes the middleware array:

• https://github.com/rails/rails/blob/cfc48d0b5f363cc880237d2e25598c64c9eb8400/railties/lib/rails/application/finisher.rb#L46
• https://github.com/rails/rails/blob/3cac5fe94f0f81b4263cfa03d4822c05a55eb49c/railties/lib/rails/application.rb#L515
• https://github.com/rails/rails/blob/3cac5fe94f0f81b4263cfa03d4822c05a55eb49c/railties/lib/rails/engine.rb#L505
• https://github.com/rails/rails/blob/fc5dd0b85189811062c85520fd70de8389b55aeb/actionpack/lib/action_dispatch/middleware/stack.rb#L100

From the stack trace in this issue, it looks like when sentry-raven inserts its middleware it is happening after the middleware array has been frozen.

I don’t see how factory_bot_rails could have much effect here, since we don’t do anything with middleware at all, but we did just got a new issue about this: #303.

In my case issue was caused by rails_admin recent upgrade:

RuntimeError:
  Required middlewares for RailsAdmin are not added
  To fix tihs, add

    config.middleware.use ActionDispatch::Flash

  to config/application.rb.