thorvg: Tests failing on Windows using MSVC
Hi all,
The new static png and jpg loaders are compiling perfectly on Windows x64 MSVC. However when I run the tests, I get 4 errors.
Summary:
ThorVG version: 0.5.99
Build Type: release
Prefix: c:/
SIMD Instruction: none
Raster Engine (SW): true
Raster Engine (GL): false
Loader (TVG): true
Loader (SVG): true
Loader (PNG): true
Loader (JPG): true
Saver (TVG): true
CAPI Binding: false
Log Message: true
Tests: true
Examples: false
Tool (Svg2Tvg): false
Tool (Svg2Png): false
User defined options
backend : ninja
buildtype : release
debug : false
default_library: static
loaders : all
log : true
savers : tvg
tests : true
../test/testPicture.cpp(139): FAILED:
REQUIRE( picture->load(data, size, "", false) == Result::Success )
with expansion:
5 == 0
../test/testPicture.cpp(183): FAILED:
REQUIRE( picture->load(data, size, "", false) == Result::Success )
with expansion:
5 == 0
../test/testScene.cpp(68): FAILED:
REQUIRE( scene->reserve(-1) == Result::FailedAllocation )
with expansion:
0 == 3
../test/testSwCanvasBase.cpp(43): FAILED:
REQUIRE( canvas->reserve(-1) == Result::FailedAllocation )
with expansion:
0 == 3
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 17 (14 by maintainers)
Commits related to this issue
- tvg_saver: fixing file opening mode Opening files in text mode on windows can cause issues. Fixed by changeing the mode to binary. @Issue: https://github.com/thorvg/thorvg/issues/957 @Issue: https:/... — committed to mgrudzinska/thorvg by mgrudzinska a year ago
- tvg_saver: fixing file opening mode Opening files in text mode on windows can cause issues. Fixed by changeing the mode to binary. @Issue: https://github.com/thorvg/thorvg/issues/957 @Issue: https:/... — committed to thorvg/thorvg by mgrudzinska a year ago
@hermet presented log is correct, no
<svg/>tag comes from searching the type of a loader:REQUIRE(picture->load(data, size, "", false) == Result::Success);I believe that solving #1380 will solve also this problem. I’m working on #1380
@mgrudzinska I’m appreciated if you help this issue.
I will check 😃