hass-browser_mod: Popup Card is no longer working
My Home Assistant version: 0.XX.X
What I am doing: I am using popup cards within browser_mod to open up remotes for my tvs when the entity for the remote is pressed. This was working fine for several months until today.
What I expected to happen: Clicking my remote entity opens the popup with my built remote control
What happened instead: The more info dialog for the entity is opened
Minimal steps to reproduce:
- Create a popup card
- Populate the popup card with a custom lovelace card
- Link this to any entity
- Click the entity
type: custom:popup-card
entity: remote.millennium_falcon
dismissable: true
card:
type: custom:android-tv-card
remote_id: remote.millennium_falcon
slider_id: media_player.millennium_falcon
media_player_id: media_player.millennium_falcon
keyboard_id: media_player.android_tv_192_168_86_54
rows:
- - power
- search
- home
- - emby
- youtube
- keyboard
- - back
- volume_down
- volume_up
- - touchpad
title: Millennium Falcon Remote
By replacing the space in the checkboxes ([ ]) with an X below, I indicate that I:
-
[X ] Understand that this is a channel for reporting bugs, not a support forum (https://community.home-assistant.io/).
-
[X ] Have made sure I am using the latest version of the plugin.
-
[ X] Have followed the troubleshooting steps of the “Common Problems” section of https://github.com/thomasloven/hass-config/wiki/Lovelace-Plugins.
-
[X ] Understand that leaving one or more boxes unticked or failure to follow the template above may increase the time required to handle my bug-report, or cause it to be closed without further action.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 11
- Comments: 31 (4 by maintainers)
brooo… That effing works wonders! I already use layout card so wrapping the popups in one took 2sec for me. You dont even need to set up areas/layout etc, you can just add a layout-card -> go directly to cards -> add popup card and done. The preview of the popup card is still broken though, but it works!
so basically just…
I´ve made a fork that fixes this issue until/if we ever get an actual update. https://github.com/mellamomax/hass-browser_modpop/
This is a combined fork of:
raymercury’s repository with #619, which addresses pop-ups showing in fullscreen on mobile.
For the popup not working with HA 2024.7.X, @sebastian-bartkowiak had a solution with #732.
NOTE: Pop-up cards still show as blank in edit mode_
Steps to implement:
Done! It should work immediately.
OK, so I have successfully got rid of the issue by commenting out two lines in
js/plugin/popup-card.tsfile -this.removeAttribute("hidden");andthis.setAttribute("hidden", "");.My understanding is - this parameter hides
LitElementfrom the view, which (just recently) started to be respected by HA frontend (with “visibility” tab). The thing is - popup element is either way being displayed differently (withwindow.browser_mod?.service("popup", ...)method), so we don’t really have to tell HA frontend whether popup element is displayed or not.As far as I can tell there are no side effects of this, but then again - I have zero experience with HA frontend, so I might overlook some things.
Yea, so actually it’s not that simple to fix it by yourself. The distributed file is transpiled and bundled together with the rest of TS files. As far as I can see there are three options:
browser_mod.jsand remove those two lines - that might be easier than the other option, but will only affect the browser you do this operation onbrowser_mod.jsfile being served by HA to all connecting frontends. for that puropuse you would have to modify/config/custom_components/browser_mod/browser_mod.jsfile (be sure to make a backup just in case!) to get rid of those lines mentioned above (in my case those expressions are located in line 305, you have to replace"hui-card-preview"===this.parentElement.localName?(this.editMode=!0,this.removeAttribute("hidden")):this.setAttribute("hidden","")with"hui-card-preview"===this.parentElement.localName&&(this.editMode=!0)). on top of that you will probably have to rename/delete/config/custom_components/browser_mod/browser_mod.js.gzfile, as it is an cached, compressed version of the library - with that in place you will still be served old version of thebrowser_mod.jsfile EDIT: obviously - be sure to clear browser/app cache, as usually when changing lovelace cards files!@thomasloven Could you look into this problem and fix it? Since the last update, the popups no longer work via the “more info” way.
Yes, can confirm the above fix from @sebastian-bartkowiak works for me too.
OK, I poked around to find the cause of the issue.
The core issue for me seems to be located in file
js/plugin/popup-card.tsThere you can find two functions -connectedCallback&disconnectedCallback- their primary goal is to attach event listener towindowinstance listening forhass-more-infoevents being fired by the DOM. Now, the issue is - the event listeners are attached inconnectedCallbackproperly, but immediately after that they are being detached bydisconnectedCallbackcalled from HA itself. It seems to me thatdisconnectedCallbackis called because of newly added functionality on HA side, which is “visibility”. The code checking whether a card is visible or not looks at “popup” card and desides that it is, in fact, not visible (which is frankly true), and because of that it disconnects it from the rest of the frontend. Furthermore, when you try to edit “popup” card via GUI you will notice that it’s preview is not rendered at all. I suspect that the nature of this card (normally hidden, and only shown programmatically in specified conditions) just does not go along with how “visibility” was implemented on HA side. Quick dirty fix I can think of is just removingwindow.removeEventListener("hass-more-info", this.popup);line, but I am sure that will have some further implications down the line.Full disclaimer - I have no experience with HA frontend coding, so I might get something of it wrong 😃
Same issue here. I’m using the latest layout changes in 2024.7.x which I assume is part of the issue.
Honestly wish HA would just support a native solution for this given people want to have more control over their interfaces.
the layout-card is a work-around (until we find a fix for the popup card self) but it adds an empty space in the dashboard. Where the 2 red squares there are the 2 layout-cards. but better then no popup function currently ^^
//Edit: OK with the Layout Card i grouped now all Pop-up cards into one single Layout card and simply moved it to the bottom as Last Card in the Dashboard. Problem with empty space betweens cards solved.
Hi all, I want to share my finding. Despite problem with more-info popup in frontend 20240705.0, this is still working if is enclosed in bootstrap-grid-card. This means, if whatever entities in whatever cards and custom:popup-card(s) for those entities enclosed in same bootstrap-grid-card. bootstrap-grid-card This is not solution, but for me is life saver, because my dashboards heavily depends on custom more-info popups.
I also set up a new dashboard with Bubble Cards, but I still have use for this feature; it’s nice being able to override the more info box for specific entities
Thanks for sharing! I was wondering why some popups still work since 2024.7.x. I found that the more-info popups also work if they are enclosed in a View layout card
Be carefull with the layout syntax. https://github.com/thomasloven/lovelace-layout-card/issues/288#issuecomment-2143824572
I can confirm, it was stop working in version 2024.7
My simple example:
Instead poping up this entities card on click, generic more info popup appeared.