react-native-video: [BUG]: basic sample project in repo on iOS doesn't show textTracks

Version

v6 (Beta)

What platforms are you having the problem on?

iOS

Architecture

Old architecture

What happened?

I ran the basic sample app (on master) and was trying to find a working example of the textTracks on iOS since I can’t get it to work on my own sample repo. I expected to see subtitles/captions since the title of this one says subtitles.

Screenshot 2024-04-02 at 2 43 02 PM

Reproduction

repository link

Reproduction

Step to reproduce this bug are:

  1. Run git clean -xdf && yarn xbasic install && cd examples/basic/ios && pod install && cd - && yarn xbasic ios*
  • At this point I noticed my Podfile.lock had some differences with git diff COCOAPODS: 1.15.2
  1. Click channel up until reaches ‘sintel with sideLoaded subtitles’, watch until audio occurs.

Observe no captions/subtitles.

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 17 (9 by maintainers)

Most upvoted comments

I just push a branch with a first fix. Still need to understand why side loaded textTracks cannot be selected

It’s already here CleanShot 2024-04-19 at 13 57 53@2x

We do some magic with AVMutableCompositionTrack to add subtitles to video - and we cannot use streams such as HLS. I found this information going through the forums like stackoverflow & apple forum (not sure if it is somewhere in docs)

Ok, thanks! Your looks good, I think you should add this information in documentation (for the m3u) ! Btw , please let me cross check the behavior on 5.2

We do some magic with AVMutableCompositionTrack to add subtitles to video - and we cannot use streams such as HLS. I found this information going through the forums like stackoverflow & apple forum (not sure if it is somewhere in docs)

@freeboub @paulrinaldi I have good news - I have fixed sideload for subtitles! I will make PR soon. One thing that is very important is that sideload subtitles will not work for HLS streams (m3u8)

I started to investigate yesterday, looks like a regression from swift promise removal ( ping @KrzysztofMoch ) I will push my changes today even if I am not sure everything works fine. (I will have very limited time next week). I am talking about the " sintel with subtitles " the sideloaded subtitles also don’t work but it is another issue, I didn’t find the root cause yet

Are you able to use SelectedTrackType.Language value: 'en' ? or do you have to use the index?

@paulrinaldi are you able to see the text tracks on the dragon video? its the sintel one.

Even when I set selectedTextTrack={{type: 'index', value: 0}}, it does not show them.