kirki: Kirki_Fonts_Google::$force_load_all_variants doesn't work anymore

Issue description:

Force loading Google Font variants doesn’t work after 3+ with code bellow. I used it for body font, so the user can use regular, bold, italic in post editor. I believe that multi-select variant would be really proper solution.

Version used:

3.0.4

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

add_action( 'wp', function() {
	if ( class_exists( 'Kirki_Fonts_Google' ) ) {
		Kirki_Fonts_Google::$force_load_all_variants = true;
	}
});

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 15 (3 by maintainers)

Most upvoted comments

@aristath - I’m afraid that loading all variants is actually not working, after all … At least when hooked to after_setup_theme … Perhaps another hook ? “init” or … ? I don’t understand how you don’t see the relevance of loading multiple variants per typography control. When someone writes a blog post, it’s very common thing that he/she wants to use bolds, italics or other variants to emphasize or quote or whatever - that’s why you have “the editor” (with “Bold”, “Italic” buttons …). If you make choice to use “typography” control for body text, and be able to choose only one variant, for example “400”, the bolds, italics (available for font, for example “Roboto”), won’t display (properly). As it does not to me … Off course, loading all variants for all typography controls is surely heavy to load, but leaving users without possibility to make different font weights/styles in posts, pages …

Like I already said before - adding multiselect capability to “variant” field would be effective - for example - for headings the use can pick only ONE variant (bold, for example), and for body can pick :400,400 italic, 800, 800italic. That actually would increase load time, but not nearly as much as loading all variants …

Micemade on Sep 10, 2017

@Micemade, Indeed, it would be better, for example I do not use 800, 900 and I do not need them to load too.

vlthemes on Sep 10, 2017

@Micemade I will think more about your idea. Maybe it will available in next version.

Khoapq on Apr 20, 2018

Wow, man - great ! I will surely check it ! Thanks for sharing … 😃

Micemade on Apr 20, 2018

I have a plugin (add on for Kirki) allow load all or multiple variants. Download: https://wordpress.org/plugins/customize-kirki-variants/

Hope this plugin useful for you.

Khoapq on Apr 20, 2018

@xttn some questions:

Why include all variants and subsets? Adding everything will make client sites extremely slow if they use 3 fonts that have lots of variants/subsets. Why not simply include the extra variants you need using this? https://github.com/aristath/kirki/issues/992#issuecomment-302928437
Why are you adding that function in after_setup_theme ?
Is this using the 3.0.9 version from wordpress.org, or using the develop branch from this repository? If you haven’t tried the develop branch can you please try it?

aristath on Sep 8, 2017

Sorry, I wasn’t able to reply sooner - I was away from computer. It seems it works ( I see you already included fix in wp.org update ). Thank you very much.

Micemade on Jun 26, 2017

Yes, that works ! Thank you very much @vlthemes ! Although I have tried with “after_setup_theme”, but I didn’t include Kirki_Fonts_Google::$force_load_all_subsets = true … Thought it wasn’t necessary, because I just wanted all variants, not subsets … Anyhow, big thanks !

Micemade on Jun 25, 2017