BootsFaces-OSP: Adding a Navbar to a stateless page causes a session to be created
Open source work often goes unthanked, so thank you for being great stewards of BootFaces. We love the framework.
I’m not completely convinced this is a bug in BootsFaces, but I figured I’d log a bug anyway. We noticed that adding a Navbar (and likely any bootsfaces components) will cause a session to get created, even on a page with a stateless view. We’re running Apache TomEE 7.0.6 which uses OpenWebBeans 1.7.6 and MyFaces 2.2.12. I grabbed a stack trace so you can see how it gets created.
It could be that CDIManagedBeanHandlerImpl needs to be a little smarter and not dip down into the session when on a stateless view.
SessionContext.<init>() line: 39
CdiAppContextsService(WebContextsService).initSessionContext(Object) line: 480
CdiAppContextsService(WebContextsService).startContext(Class<Annotation>, Object) line: 311
BeginWebBeansListener.sessionCreated(HttpSessionEvent) line: 150
StandardSession.tellNew() line: 388
StandardSession.setId(String, boolean) line: 360
StandardSession.setId(String) line: 341
StandardManager(ManagerBase).createSession(String) line: 656
Request.doGetSession(boolean) line: 3087
Request.getSession(boolean) line: 2476
RequestFacade.getSession(boolean) line: 896
CdiAppContextsService(WebContextsService).lazyStartSessionContext(boolean) line: 820
CdiAppContextsService(WebContextsService).getSessionContext(boolean) line: 737
CdiAppContextsService(WebContextsService).getCurrentContext(Class<Annotation>) line: 277
BeanManagerImpl.getContext(Class<Annotation>) line: 291
SessionScopedBeanInterceptorHandler(NormalScopedBeanInterceptorHandler).getContextualInstance() line: 89
SessionScopedBeanInterceptorHandler.getContextualInstance() line: 76
SessionScopedBeanInterceptorHandler(NormalScopedBeanInterceptorHandler).get() line: 71
ViewScopeBeanHolder$$OwbNormalScopeProxy0.generateUniqueViewScopeId() line: not available [local variables unavailable]
CDIManagedBeanHandlerImpl.generateViewScopeId(FacesContext) line: 92
ViewScopeProxyMap.getWrapped() line: 79
ViewScopeProxyMap.get(Object) line: 119
AddResourcesListener.addResource(String, String, String, String) line: 896
AddResourcesListener.addResourceToHeadButAfterJQuery(String, String) line: 839
Tooltip.addResourceFiles() line: 134
NavBar.<init>() line: 52
NativeConstructorAccessorImpl.newInstance0(Constructor<?>, Object[]) line: not available [native method]
NativeConstructorAccessorImpl.newInstance(Object[]) line: 62
DelegatingConstructorAccessorImpl.newInstance(Object[]) line: 45
Constructor<T>.newInstance(Object...) line: 423
Class<T>.newInstance() line: 442 [local variables unavailable]
ApplicationImpl.createComponent(FacesContext, String) line: 1442
ApplicationImpl.createComponent(FacesContext, String, String) line: 1405
OwbApplication(ApplicationWrapper).createComponent(FacesContext, String, String) line: 123
OmniApplication(ApplicationWrapper).createComponent(FacesContext, String, String) line: 123
ComponentTagHandlerDelegate.createComponent(FaceletContext) line: 605
ComponentTagHandlerDelegate.apply(FaceletContext, UIComponent) line: 285
ComponentHandler(DelegatingMetaTagHandler).apply(FaceletContext, UIComponent) line: 50
CompositeFaceletHandler.apply(FaceletContext, UIComponent) line: 46
HtmlComponentHandler(DelegatingMetaTagHandler).applyNextHandler(FaceletContext, UIComponent) line: 55
ComponentTagHandlerDelegate.apply(FaceletContext, UIComponent) line: 374
HtmlComponentHandler(DelegatingMetaTagHandler).apply(FaceletContext, UIComponent) line: 50
CompositeFaceletHandler.apply(FaceletContext, UIComponent) line: 46
ViewHandler.apply(FaceletContext, UIComponent) line: 195
CompositeFaceletHandler.apply(FaceletContext, UIComponent) line: 46
NamespaceHandler.apply(FaceletContext, UIComponent) line: 59
CompositeFaceletHandler.apply(FaceletContext, UIComponent) line: 46
CompositeFaceletHandler.apply(FaceletContext, UIComponent) line: 46
EncodingHandler.apply(FaceletContext, UIComponent) line: 48
DefaultFacelet.apply(FacesContext, UIComponent) line: 189
FaceletViewDeclarationLanguage.buildView(FacesContext, UIViewRoot) line: 477
RenderResponseExecutor.execute(FacesContext) line: 78
LifecycleImpl.render(FacesContext) line: 267
FacesServlet.service(ServletRequest, ServletResponse) line: 200
ApplicationFilterChain.internalDoFilter(ServletRequest, ServletResponse) line: 231
ApplicationFilterChain.doFilter(ServletRequest, ServletResponse) line: 166
WsFilter.doFilter(ServletRequest, ServletResponse, FilterChain) line: 52
ApplicationFilterChain.internalDoFilter(ServletRequest, ServletResponse) line: 193
ApplicationFilterChain.doFilter(ServletRequest, ServletResponse) line: 166
RewriteFilter.doFilter(ServletRequest, ServletResponse, FilterChain) line: 226
ApplicationFilterChain.internalDoFilter(ServletRequest, ServletResponse) line: 193
ApplicationFilterChain.doFilter(ServletRequest, ServletResponse) line: 166
ApplicationDispatcher.invoke(ServletRequest, ServletResponse, ApplicationDispatcher$State) line: 728
ApplicationDispatcher.processRequest(ServletRequest, ServletResponse, ApplicationDispatcher$State) line: 470
ApplicationDispatcher.doForward(ServletRequest, ServletResponse) line: 395
ApplicationDispatcher.forward(ServletRequest, ServletResponse) line: 316
HttpRewriteResultHandler.handleResult(Rewrite) line: 42
RewriteFilter.rewrite(InboundServletRewrite<ServletRequest,ServletResponse>) line: 297
RewriteFilter.doFilter(ServletRequest, ServletResponse, FilterChain) line: 198
ApplicationFilterChain.internalDoFilter(ServletRequest, ServletResponse) line: 193
ApplicationFilterChain.doFilter(ServletRequest, ServletResponse) line: 166
StandardWrapperValve.invoke(Request, Response) line: 199
StandardContextValve.invoke(Request, Response) line: 96
OpenEJBValve.invoke(Request, Response) line: 44
NonLoginAuthenticator(AuthenticatorBase).invoke(Request, Response) line: 493
StandardHostValve.invoke(Request, Response) line: 137
ErrorReportValve.invoke(Request, Response) line: 81
OpenEJBSecurityListener$RequestCapturer.invoke(Request, Response) line: 97
AccessLogValve(AbstractAccessLogValve).invoke(Request, Response) line: 660
StandardEngineValve.invoke(Request, Response) line: 87
CoyoteAdapter.service(Request, Response) line: 343
Http11Processor.service(SocketWrapperBase<?>) line: 798
Http11Processor(AbstractProcessorLight).process(SocketWrapperBase<?>, SocketEvent) line: 66
AbstractProtocol$ConnectionHandler<S>.process(SocketWrapperBase<S>, SocketEvent) line: 808
NioEndpoint$SocketProcessor.doRun() line: 1498
NioEndpoint$SocketProcessor(SocketProcessorBase<S>).run() line: 49
ThreadPoolExecutor(ThreadPoolExecutor).runWorker(ThreadPoolExecutor$Worker) line: 1149
ThreadPoolExecutor$Worker.run() line: 624
TaskThread$WrappingRunnable.run() line: 61
TaskThread(Thread).run() line: 748
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Reactions: 1
- Comments: 19 (11 by maintainers)
Commits related to this issue
- Fix #1117 - Navbar causes session creation. Use a private static concurrent map instead of the server session — committed to exabrial/BootsFaces-OSP by deleted user 7 years ago
i have make a test - if store the data in root.attributes i has the old bug form the https://github.com/TheCoder4eu/BootsFaces-OSP/issues/1066
if i store the data into root.viewMap(true) the old bug is fixed
@exabrial to use JSF without a session is not so easy - you have in your example an <f:view … transient=“true”> but when I add a <h:form> also a session is started - that was not the expected behavior - I have change for the AddResourcesListener.java class in my PR the function for three checks if we can use the view map - transient view, http session and if a form exists
I thought more in the direction of the MVC pattern on which JSF is based.
with a partial AJAX update to a request scoped page, you still need a session because you want to remember which resources have already been loaded by the browser
These days I’m mostly occupied with another open source project of mine, but I must admit your bug looks interesting. I’m not sure I can reproduce it quickly. Would you mind to send us a reproducer? I.e. a small, minimal program showing the bug without requiring any configuration? In particular, no database?
Thanks in advance, Stephan
Thanks for the kind words! BootsFaces is a leisure time project, so a little “thumbs up!” means a lot to us!