youtube-music: [Bug]: Menu Bar disappear and plugin not working

Preflight Checklist

  • I use the latest version of YouTube Music (Application).
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I understand that th-ch/youtube-music has NO affiliation with Google or YouTube

YouTube Music (Application) Version

3.5.1 All version including 3.5.3 fix

Checklists

What operating system are you using?

Windows

Operating System Version

Windows 11 23H2 22631.3737

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

3.4.1

Reproduction steps

1. using winget upgrade -h th-ch.YouTubeMusic to update from 341 to 351 2. login google account can not be reproduce on my other w10 PC

Expected Behavior

work as normal with setting up plugin at menu bar

Actual Behavior

MenuBar disappear, no way to access the setting and all plugin not working

Enabled plugins

Exponential Volume askbar Media Control

Additional Information

reinstall seems not help and if i logout my account, all plugin just works

after one reinstallation,the logout method also not work

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 36 (5 by maintainers)

Commits related to this issue

Most upvoted comments

@huangxd- @nshannon123 @cdsoftw @JellyBrick @ArjixWasTaken It seems that this bug no longer occurs after the 3.7.0 version.

Yes can confirm - still not working.

To add to @szl0834 's comment - the code around lines 850-855 are:

      , Se = n => {
        const e = document.createElement("template");
        return n = n.trim(),
        e.innerHTML = n,
        e.content.firstElementChild
    }

Failing at e.innerHTML = n,

I can see in the hotfix that a trusted policy was created in the code - but it isn’t being used on the n string variable. The createHTML method from the policy should be used on n to convert it to a “Trusted Type”

Unfortunately - still getting the error with the latest fix. Tried signing out and back in and reinstall etc. Funny enough - the menu bar does appear on the login page - but I wonder if that’s something to do with it being a Google login page or something.

This document requires ‘TrustedHTML’ assignment. Se @ youtube-music.iife.js:862 (anonymous) @ youtube-music.iife.js:863 (anonymous) @ youtube-music.iife.js:1886 (anonymous) @ VM125 C:\Users\Niall.shannon\AppData\Local\Programs\youtube-music\resources\app.asar\dist\preload\preload.js:158 (anonymous) @ VM125 C:\Users\Niall.shannon\AppData\Local\Programs\youtube-music\resources\app.asar\dist\preload\preload.js:160 Module._compile @ VM63 loader:1484 Module._extensions…js @ VM63 loader:1564 Module.load @ VM63 loader:1295 Module._load @ VM63 loader:1111 c._load @ VM76 node_init:2 s._load @ VM121 renderer_init:2 (anonymous) @ VM121 renderer_init:2 (anonymous) @ VM121 renderer_init:2 _electron_webpack_init @ VM121 renderer_init:2 (anonymous) @ VM121 renderer_init:2 compileForInternalLoader @ VM10 realm:398 compileForPublicLoader @ VM10 realm:337 loadBuiltinModule @ VM46 helpers:104 Module._load @ VM63 loader:1083 c._load @ VM76 node_init:2 executeUserEntryPoint @ VM69 run_main:189 (anonymous) @ VM73 run_main_module:28 youtube-music.iife.js:862

Uncaught TypeError: Failed to set the ‘innerHTML’ property on ‘Element’: This document requires ‘TrustedHTML’ assignment. at Se (youtube-music.iife.js:862:4605) at youtube-music.iife.js:863:8804 at youtube-music.iife.js:1886:1608

@szl0834 Wasn’t it @JellyBrick looking at the issue?

I don’t have plans of looking into this issue.

Note: I have stepped down from being a maintainer, I am just a contributor now, so I only do stuff that interests me.

anyone else frustrated by this issue and the lack of either progress or communication despite a new version release

We’re not paid developers, and it’s hard to fix issues that we can’t reproduce.

Huh, when did it become the default? (Not saying that it isn’t the default)

btw, is my clean install step correct?

  1. Uninstall using Uninstall YouTube Music.exe
  2. Delete %AppData%/Local/youtube-music-updater
  3. Delete %AppData%/Roaming/YouTube Music
  4. Reinstall

Can confirm - happened to me as well - youtube-music.iife.js failing to execute line 837 due to “This document requires ‘TrustedHTML’ assignment” error in dev console