tt-metal: Pack Untilize gives bad PCC when block_ct_dim < full_ct_dim
Describe the bug for Conv unit test, block_ct_dim=1, full_ct_dim = 2, pack_untilize gives garbage PCC, when set block_ct_dim= full_ct_dim=2, PCC is good.
To Reproduce Steps to reproduce the behavior:
- Go to
yugao/pack_untilize - Run
pytest tests/ttnn/unit_tests/operations/test_new_conv2d.py::test_unet_conv_wh - To get rid of the PCC error, comment out the hard-coded
out_subblock_h_ntiles = 1; out_subblock_w_ntiles = 1;inttnn/cpp/ttnn/operations/conv/conv2d/conv2d.cpp
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 20 (18 by maintainers)
Commits related to this issue
- #11573: WIP add missing pack_untilize params — committed to tenstorrent/tt-metal by rtawfik01 2 years ago
- #11573: WIP add missing pack_untilize params — committed to tenstorrent/tt-metal by rtawfik01 2 years ago
- #11573: WIP add missing pack_untilize params — committed to tenstorrent/tt-metal by rtawfik01 2 years ago
- #11573: WIP add missing pack_untilize params — committed to tenstorrent/tt-metal by rtawfik01 2 years ago
- #11573: Added compute kernel pack_untilize support for block_ct_dim != full_ct_dim — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- Fix pack_untilize for block_ct_dim != full_ct_dim (#236) ### Ticket [#11573](https://github.com/tenstorrent/tt-metal/issues/11573) ### Problem description Untilize operation can be performed either u... — committed to tenstorrent/tt-llk by pmilenkovicTT a year ago
- Fix pack_untilize for block_ct_dim != full_ct_dim (#236) ### Ticket [#11573](https://github.com/tenstorrent/tt-metal/issues/11573) ### Problem description Untilize operation can be performed either u... — committed to tenstorrent/tt-llk by pmilenkovicTT a year ago
- #11573: Replace untilize with pack_untilize and fix block_ct_dim != full_ct_dim issue — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Replace untilize with pack_untilize and fix block_ct_dim != full_ct_dim issue — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Replace untilize with pack_untilize and fix block_ct_dim != full_ct_dim issue — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Replace untilize with pack_untilize and fix block_ct_dim != full_ct_dim issue — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Added support for full_ct_dim > 8 — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Added support for full_ct_dim > 8 — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Added support for full_ct_dim > 8 — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Added support for full_ct_dim > 8 — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Added description for parameters — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Added support for full_ct_dim > 8 — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Added support for full_ct_dim > 8 — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Added support for full_ct_dim > 8 — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
- #11573: Adjusted CMakeLists — committed to tenstorrent/tt-metal by pmilenkovicTT a year ago
Resolved it with @avoraTT offline, the issue was improper usage of
pack_untilize_block- no LLK changes necessary.Hey @yugaoTT, I created a PR for the LLK changes on WH that enable the block_ct_dim != full_ct_dim case to work. Could you please take a look at my branch on tt_metal to see the necessary op changes for the algorithm to work? Here is the test that I used for it:
Hi @yugaoTT, there is an open bug that full_ct_dim != block_ct_dim does not work currently in the LLKs, there is a mention of it here: https://github.com/tenstorrent/tt-metal/issues/11716
If this issue becomes higher priority then the LLK team can work on fixing this issue for pack_untilize, please let us know.
fyi @mywoodstock