tensorflow: DOC: CONTRIBUTING.md Sanity Check guide not working
If I try running the instructions in CONTRIBUTING.md:
tensorflow/tools/ci_build/ci_build.sh CPU tensorflow/tools/ci_build/ci_sanity.sh
I get:
#10 1.118 /install/install_pip_packages.sh: line 21: python3.6: command not found
However, if I instead use the cpu-py3.6 image, I get a bit further:
addgroup: Please enter a username matching the regular expression configured via the NAME_REGEX[_SYSTEM] configuration variable.
Use the `--force-badname' option to relax this check or reconfigure NAME_REGEX.
I don’t see any way for users to fix this without diving into the plethora of different Dockerfiles and scripts-calling scripts that exist in the repo.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 23 (15 by maintainers)
Yes but someone working at Google has to manually trigger that AFAIK, which introduces several days of lag every time tests need to be run. And as we all know you can be trying to fix one issue only to create another, etc. Something that should take hours ends up taking weeks.
Testing, especially “sanity”/linting but arguably unit tests as well, should be easy and fast to run so that developers can get feedback on their changes ASAP and iterate.
@angerson Just a reminder. If we are working in a Docker container these scripts require Docker in Docker and I it is not the best experience.