what-input: activeElement can be null
I’m sometimes getting an error on from this line while testing in IE11. Apparently, activeElement can be null, so the line throws an error. I don’t think it materially affects the script, but maybe an existence check there would be an improvement? If I get around to it, I can open a PR, but figure I should flag you on it.
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Reactions: 2
- Comments: 27 (13 by maintainers)
Commits related to this issue
- Make activeElement a bit safer, ref #38 — committed to ten1seven/what-input by ten1seven 8 years ago
- Update activeElement check, ref #38 — committed to ten1seven/what-input by ten1seven 8 years ago
- Adding check for nodeName, ref #38 — committed to ten1seven/what-input by ten1seven 7 years ago
- Update conditional logic to maintain activeElement check, ref #38 — committed to ten1seven/what-input by ten1seven 5 years ago
Ah, yep yep, thanks for catching that conditional logic error! I made this update https://github.com/ten1seven/what-input/commit/a73ddbad6c497fb38a6f6f98ec7b765887d7b1c7 and created a pre-release. Would you or anyone else following this thread be able to give it a test to see if that resolves the error?
https://github.com/ten1seven/what-input/releases/tag/v5.2.2