taskcluster: The Log viewer URI decodes the artifact URL incorrectly if a bewit is specified

Describe the bug If a bewit is specified for a log artifact, the log viewer incorrectly decodes the artifact URL multiple times, destroying the artifact name and resulting in a 401 message.

To Reproduce Steps to reproduce the behavior:

Make sure that queue:get-artifact:public/* is not granted to anonymous.
Run a task and wait for it to complete.
Click on the backing artifact log link.
(Chrome only) Notice that the page loads correctly, press F5.
Notice the 401 error.

Expected behavior The log should be displayed correctly.

Taskcluster version v38.0.1

Screenshots https://i.snipboard.io/n0GZL6.jpg

Platform (please complete the following information):

OS: Windows 10
Chrome: 86
Firefox: 82.0.2

Additional context The error that yields the 401 is ‘Bad mac’ which is caused by the URL being decoded one time too many.

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 15

Commits related to this issue

Set up PulseEngine before setting onConnected hook This fixes an (apparently harmless?) error that appears in the UI when viewing the TaskGroup page, as noted in #3831. — committed to djmitche/taskcluster by djmitche 4 years ago

Most upvoted comments

I can reproduce this in my dev environment with a full anonymous role (not that surprising – it’s a 401, not a 403, so scopes are not consulted)

djmitche on Nov 4, 2020