table: Table doesn’t re-render with new React Compiler + React 19
TanStack Table version
v8.17.3
Framework/Library version
React 19 + React Compiler
Describe the bug and the steps to reproduce it
In the repo provided, run bun install and then bun dev.
Then, add some text to the input and click add. Observe that the table doesn’t re-render when the data passed in has changed (table.getRowModel().rows doesn’t seem to be updated).
Your Minimal, Reproducible Example - (Sandbox Highly Recommended)
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
None
Terms & Code of Conduct
- I agree to follow this project’s Code of Conduct
- I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
About this issue
- Original URL
- State: open
- Created 3 years ago
- Reactions: 66
- Comments: 29 (3 by maintainers)
Commits related to this issue
- fix: table rerender infinitely https://github.com/TanStack/table/issues/5567 — committed to bsol-oss/react-datatable5 by jacky-ng-w3b 2 years ago
TanStack Table’s React Binding has an API design that doesn’t allow you to follow the Rules of React (or React Inherichy), thus when used with React Compiler it breaks.
E.g. see this commonly used API:
This function
getHeaderGroupsis invoked in the render phase, thus React expects/requires this to be a pure function, i.e.getHeaderGroups’s return value will only change when its parameter is changed. SincegetHeaderGroupshas 0 parameters, with the pure-function-only assumption/expectation, React Compiler memos the returned value oftable.getHeaderGroups()with 0 dependencies. However,table.getHeaderGroups()is not a pure function. Even without parameters, the return value will change during re-render, hence violating the rule of react.The same applies to
table.getRowModel().In short, If you are using TanStack Table’s React Binding, TanStack Team is forcing you to violate the Rule of React by forcing you to use un-pure functions in the render phase.
See also the React Docs: https://react.dev/reference/rules/components-and-hooks-must-be-pure#return-values-and-arguments-to-hooks-are-immutable
The issue just demonstrates how much React knowledge the maintainers have.
Yep, use no memo on table components for now. A v9 alpha branch was recently created where we will focus on version bumping the peer dependencies for each framework that needs it.
Please upgrade to support react 19 and next.js 15.
This comment just demonstrates how little respect you have for people who wrote a library you have found useful. Just because historical design choices aren’t compatible with an experimental new compiler doesn’t mean they don’t understand. It’s attitudes like this that burn out OSS maintainers. The rest of your comment provides value to understand why the issue is happening, and the snark is just uncalled for.
I’ve the same problem with Next.js 15 & React 19 & Tanstack Table 8.20.5
use no memoin table component solves the problem.In an ideal world, yes, pure functions are great. In the real world, tradeoffs are made for performance reasons. The react compiler is trying to bring those two closer together. For a table library that can deal with huge amounts of data and has critical performance needs, it’s not surprising that they made some choices to make the end user experience better. If the compiler can offload some of those choices, it’s a win for maintainability and the ecosystem, but it’s going to take some work to change the architecture.
The React core team is well aware of the tanstack ecosystem, and table in particular, and had this to say about the current situation.
This is unsurprising. This library (which I love) has been complicated to optimize since at least v7. They core instance returned from
useReactTabledoesn’t rerender as one would expect in React, which means that the memoiziation that the compiler applies certainly breaks this library. I wouldn’t expect a fix until v9.@derekperkins
This issue has existed for 12 months now. The TanStack Team has not fixed the issue yet, nor made a response, nor given a detailed explanation, until now.
The existing workarounds were found by the community, not provided by the TanStack Team. And the true reason behind this was only explained by me (instead of the TanStack Team) after months.
The fact that you only explain my comment after the issue has been made 12 months after the issue was created.
If the issue is indeed very hard for the TanStack Team to solve and has no ETA, the community will totally understand and respect, but only if the explanation is provided.
Yet, the TanStack Team hung the community out to dry, and the earliest explanation was made by me, and your detailed explanation for why the TanStack Team can’t fix the issue was made months after I made my explanation.
No matter how many team members you ask to downvote me, I have already earned enough upvotes early on. This just shows how disappointed the community was until now.
Seems like doing the following solves it for me: https://github.com/TanStack/virtual/issues/743
I am doing table resize, copy the code from example
https://tanstack.com/table/latest/docs/framework/react/examples/column-sizing, resize not working, turns out Its react-complier issue, adduse no memofor the componnet to fix it temporarily. Plz support react 19 and react-complier.Same exact issue. We’ll have to stick with
"use no memo"directive for now for our table component.Sorry, I haven’t been following the past few threads on this discussion. We do want to eventually get TanStack Table to work with the React compiler, but as far as I can tell, it’s going to require overhauling how TanStack Table handles state management. So I don’t think V8 will be able to be compatible with the React Compiler.
This can easily be worked around by disabling the react compiler just for your hook or component that uses the
useReactTablehook.This is of course, not ideal, but the issues date back to decisions made before React recommended against the patterns that TanStack Table uses under the hood to force re-renders.
The React team is also aware of this particular issue and has documented some paths forward. This will be getting worked on, but it may still take some time for us to prepare and rescope the next v9 release, as we’re both searching for ways to have the least amount of breaking changes without compromising on the performance ceiling.
I’m not a member of the team, but I downvoted your comment because it came across as rude. Criticizing the team’s intelligence isn’t constructive and only serves to be hurtful.
You’re welcome to use a different React table component that better fits your needs, or even better, contribute a pull request to help address the issue.
ah i finally got it working, but i needed to add
'use no memo'to all files that import from@tanstack/react-table😅@victormanuelfrancodev Just add
"use no memo"on top of your fileNo, unless someone wants to help experiment with a new rerendering model
I am also having difficulty applying the compiler due to the same issue. I am concerned that other libraries might have similar issues, making the application of the compiler worrisome.