tabler: [BUG] Build failures with Beta 17

Describe the bug

After upgrading to beta 17 I have a couple of build failures with node 19.2 / node-sass 8.0. One of them is:

SassError: argument `$color-1` of `mix($color-1, $color-2, $weight: 50%)` must be a color
        on line 182 of node_modules/@tabler/core/src/scss/_variables.scss, in function `mix`
        from line 182 of node_modules/@tabler/core/src/scss/_variables.scss

Refers to

$border-color-light: mix($text-muted, #ffffff, percentage($border-light-opacity)) !default;

Can be fixed by removing !default from:

$text-muted: mix($body-color, #ffffff, percentage($text-muted-opacity)) !default;

so this error goes away when line 182 looks like this:

$text-muted: mix($body-color, #ffffff, percentage($text-muted-opacity));

I have several other issues, like Tomselect using $input-border-color in a call like this: $select-color-dropdown-border-top: mix($input-border-color, $input-bg, 0.8) !default; which fails as well, because a color is expected and not a var(): https://github.com/orchidjs/tom-select/issues/559

Some of these changes seem to be inspired by "bootstrap": "5.3.0-alpha1". Really not sure if that is the the best choice for a beta17-pre-production.

Right now I am blocked and cannot update from beta16. Any idea?

About this issue

Original URL
State: closed
Created a year ago
Comments: 20 (7 by maintainers)

Most upvoted comments

Sure, I will look through the issues and help.

And with 1.0 out of the door, you can even use a “auto release drafter” process. Since I added that to my project, releasing is just a matter of editing the automatically created release draft and clicking on “publish”. The next version is calculated automatically and the changelog added to the release as well.

You just have to use PRs for all changes with the correct labels like “Bugfix” or “Feature request” (names are configurable), then it works really well. I can add send a PR to introduce such a workflow, which really makes a new release a matter of two minutes. Any bugfix can be pushed out immediately as new version.

I think we can leave out all these tiny CSS issues for 1.0, they can be fixed in any version. But I can currently not build the latest versions, due to the problems with the Bootstrap 5.3 incompatibilities. Not sure why I am the only, probably most people just used the pre-compiled files from the release instead of bundling their own … or their builder is more error tolerant.

kevinpapst on Mar 16, 2023