ImageToolbox: Proprietary components added with latest release: blockers for F-Droid

You hadn’t either of them in before. You could use build flavors, to e.g. have one “foss” build without those proprietary components (and then probably also less features), which then could go to F-Droid.org even – and another one for PlayStore. And yes, you can do fine WITHOUT in-app-review. That’s even totally useless for an app distributed at F-Droid or via an F-Droid repo. Guess why people install it from there? Most of them don’t use PlayStore (some don’t even have a Google account at all) and thus wouldn’t install your app from there – which means they couldn’t rate it there anyway.

Btw: a single ping should suffice, no need to get nervous. I cannot always act immediately, I also have other work to do 😉

Okay, i will try to do so, firstly i want to set up ACRA, and remove firebase 🐸

(I don’t think creating different flavors to avoid using play rating is good time spending)

@IzzySoft here it is https://github.com/T8RIN/ImageToolbox/releases/tag/2.3.1

@shuvashish76 no, it was pulled in again. I did only disable the daily check, in the hope it would be solved before the monthly check would run again (apps rarely updated are only checked monthly). Unfortunately, this was not the case. I’ve just removed the APK again now and will trigger a sync manually, so it should be gone again in a few minutes.

@T8RIN I hope you can make it before the next monthly check kicks in, or I’ll have to disable updates entirely. Which could then mean the entire thing might be forgotten until someone pings me again about it, and your app never be updated 😱 (no pressure, just a friendly hint 😉)

for the play store i use a GMS update checker library

I thought they wouldn’t allow updaters at all – but well, if you only check but do not apply, they might accept that.

Avatar now is just a link to the app icon in fdroid repo, i will definitely not change it here

As you wish, though that’s nonsense. The icon there is taken from here, so you could simply include it directly. If you decide to change it, you’ll have to wait until F-Droid pulled it from here (which only happens when you provide a new release), replaced it and published a fresh index – so it won’t be “faster”, but be available at the very same time as the files inside your APK, just causing additional network overhead. And if the device is in airplane mode (or for some other reason has no network connection), it couldn’t access the file online 🤷

For Google Play I use Google’s built-in checker 👀

Ah. Can you do the same for F-Droid then? Because F-Droid has a built-in checker, too 😉

the user can check for updates himself and then if betas are enabled

Confusing. So just betas enabled does not mean only betas will be checked? Going by the screenshot, that’s what I’d expect it to mean.

But be it as it is, I don’t have the time for eternal back-and-forth unfortunately. You ship to PlayStore without your own update checker as PlayStore includes its own – I guess you simply were unaware that F-Droid includes its own as well, as else insisting on your own would not make sense. So maybe remove it entirely for the F-Droid build as well, now that you know?

I’ll do it like in the screenshot 👀 and I also changed the avatar to foss, wait in 2.4.3, I hope no one will complain anymore🐸🐸

Now in v2.4.2 it shows a dialog window during initial launch

Screenshot

Nothing really changed, in the window it’s on by default, I turned it off but during the process it still connects to github.com, avatars.githubusercontent.com. Can you please make it opt-in i.e. disable by default? I don’t think it’s clear enough for users, they’ll just click OK to everything (permissions/notices/warnings etc.) during initial launch.

Well, it’s obvious that it connects, because there is my avatar from Github🤨🤨

So it doesn’t download anything in principle, and you can turn it off in the settings…

Let me fix that for you with the suggestion to adjust accordingly in the code:

So it doesn’t download anything in principle, and you can turn it ON in the settings…

In other words: Simply switch the default to make it opt-in instead of opt-out, and this problem is solved. Though I’m not sure what the restriction with “in principle” is supposed to mean 😉

Okay

can i do this by the pre release

Oof, missed that part. Pre-releases can be enabled at my end if you wish – currently they are not. But no need anymore I guess.

Oh, that’s good, but how to add this yml?

I’ve left a comment on the other issue: both parts need to be addressed together, so it needs to wait for the other one to be solved anyway. If that’s achieved, LK will know how to use the piece I’ve provided here.

That’s fantastic! Please give me a ping once the first release has those APKs attached, so I can adjust my config here to pick those with future releases, and re-enable updates 🤩

Okay 👀

aaaaaaaaaaaaaaaaaaaaand yes, that’s definitely works, now i can introduce pure foss clean build flavor 😃)))

I’m on the way of adding product flavors