symfony: [FrameworkBundle] Unable to remove deprecation notice in FileLocator?

Symfony version(s) affected: 4.4.0 Description
When running our test suite we saw this deprecation notice:

2x: Loading the file "../src/UI/Http/Web/Controller/" from the global resource directory "/app/src" is deprecated since Symfony 4.4 and will be removed in 5.0.

…that we can’t really remove, the FrameworkBundle is injecting the $paths parameter to the FileLocator service and our routes.yaml resource, configured this way according to the docs:

web_controllers:
    resource: '../src/UI/Http/Web/Controller/'
    type: annotation

…is the one triggering this notification. AFAIK, this way of configuring the routes with relative paths is still the recommended way, but the deprecation notice seems to trigger whenever there’s a non-absolute path being loaded, even though it doesn’t use the deprecated $paths variable in order to be located, which I believe is a little bit too extreme?

About this issue

Original URL
State: closed
Created 5 years ago
Comments: 25 (17 by maintainers)

Commits related to this issue

bug #34886 [HttpKernel] fix triggering deprecation in file locator (xabbuh) This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] fix triggering deprecation in file locator | ... — committed to symfony/symfony by fabpot 5 years ago

Most upvoted comments

@relm You might have the same misconfiguration that I had: a routing file in a subdirectory of config (eg: config/routes/foo.yaml) that references a directory or a file of src relatively but that misses a .. (eg: ../src/Controller/Foo instead of ../../src/Controller/Foo).

In this case, the file is still found by the FileLocator but only thanks to the global resource directory src. The fact that the message mentions Resources is a bug that is misleading but it will be resolved by https://github.com/symfony/symfony/pull/35269. But the deprecation should still be triggered, your code is probably the problem here.

+19

fancyweb on Jan 8, 2020

Thanks, I am able to reproduce it now. Looking into it.

+10

xabbuh on Dec 2, 2019

I get this deprecation as soon as Symfony 4.4 is installed, I don’t really understand how this went unnoticed. I’ve “fixed” it too just by adding an asterisk at the end of the resource line in annotations.yaml.

Before:

controllers:
    resource: ../../src/Controller/
    type: annotation

After:

controllers:
    resource: ../../src/Controller/*
    type: annotation

jdsaphir on Nov 29, 2019

I think #34886 should solve this.

xabbuh on Dec 9, 2019

@xabbuh yes it does, just start the symfony server symfony serve and load the initial page, then go to the web toolbar to see the deprecations triggered and you will see it

acasademont on Dec 2, 2019