swc: SWC has a segfault condition

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 34 (29 by maintainers)

Commits related to this issue

Most upvoted comments

We just bumped LLVM from 16 to 17 on our CI and it appears to have fixed the crash we were seeing in Deno. It’s possible this was a miscompilation or LTO bug.

I’m curious what LLVM toolchains everyone else is using. I was never able to pin down a specific bit of UB that caused this, and our Miri builds have been clean.

@mmastrac I’ve had some concerns about potential bugs in hstr merging, but it doesn’t appear that swc_atom uses the merging functionality.

Potentially the alias field could be removed entirely to save 64 bits per unique string.

Just giving a status update on this: we upgraded to the latest swc in the latest version of Deno and haven’t run into any issues. Thanks for all the help!

Hmmm… we were able to reproduce it with just this code: https://deno.land/x/which@0.3.0/mod.ts?source=